Update devcontainer image: v1.0.2 #2723
Conversation
WalkthroughOhayo, sensei! This pull request updates the Docker image version across several configuration files related to a Rust development environment. The image version has been changed from Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.github/workflows/bench.yml (1)
Line range hint
17-39: Consider documenting version dependencies, sensei!Since this is a development environment update, it would be helpful to document any significant changes or dependencies introduced in
v1.0.2that might affect the benchmark results.Would you like me to help create a documentation template or open an issue to track this?
🧰 Tools
🪛 actionlint (1.7.4)
19-19: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (4)
.devcontainer/devcontainer.json(1 hunks).github/workflows/bench.yml(2 hunks).github/workflows/ci.yml(7 hunks).github/workflows/release-dispatch.yml(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- .devcontainer/devcontainer.json
🔇 Additional comments (5)
.github/workflows/release-dispatch.yml (2)
17-17: Ohayo sensei! The Docker image version update looks good!
The bump from v1.0.1 to v1.0.2 aligns with the changes across other configuration files in the PR.
17-17: Verify the Docker image availability
Let's ensure the new image version exists and is properly tagged in the container registry.
✅ Verification successful
Docker image ghcr.io/dojoengine/dojo-dev:v1.0.2 is available and properly tagged
The image exists in the container registry and is tagged with both v1.0.2 and latest. The image was published on November 26, 2024, and is ready for use.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the Docker image exists and is properly tagged
# Expected result: The image should exist and be tagged with v1.0.2
# Check if the image exists and get its details
gh api \
-H "Accept: application/vnd.github+json" \
"/users/dojoengine/packages/container/dojo-dev/versions" | \
jq '.[] | select(.metadata.container.tags[] | contains("v1.0.2"))'
Length of output: 782
.github/workflows/bench.yml (1)
17-17: Ohayo! Let's verify the new image version, sensei!
The update to v1.0.2 looks good, but let's ensure the image is properly tagged and available.
Also applies to: 39-39
✅ Verification successful
Ohayo sensei! The image version is properly tagged and fresh! ✨
The v1.0.2 image was created on November 26, 2024, and is also tagged as latest, confirming it's the most recent version. The image exists in the registry and is ready for use in the workflow.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the Docker image version exists and check its creation date
# Check if the image exists and when it was created
gh api \
-H "Accept: application/vnd.github+json" \
-H "X-GitHub-Api-Version: 2022-11-28" \
/orgs/dojoengine/packages/container/dojo-dev/versions \
--jq '.[] | select(.metadata.container.tags[] == "v1.0.2") | {created_at: .created_at, tags: .metadata.container.tags}'
Length of output: 326
.github/workflows/ci.yml (2)
Line range hint 13-22: Ohayo sensei! Clean artifact organization implemented.
The new binary handling approach with a dedicated bins directory and explicit copying of katana and sozo binaries improves artifact organization and clarity.
🧰 Tools
🪛 actionlint (1.7.4)
32-32: label "ubuntu-latest-32-cores" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
36-36: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
34-34: Verify Docker image version update implications
The Docker image ghcr.io/dojoengine/dojo-dev has been consistently updated to v1.0.2 across all jobs. Let's verify the version and check for any breaking changes.
Also applies to: 59-59, 126-126, 142-142, 157-157, 166-166, 175-175
✅ Verification successful
Docker image update to v1.0.2 looks good
Ohayo sensei! The update to v1.0.2 is verified and safe to proceed. The changelog shows this is a stable release with multiple improvements and bug fixes, including:
- DevContainer image updates
- Various Torii improvements (CLI, GraphQL, SQL)
- Katana enhancements
- Bug fixes and refactoring
The version is consistently updated across all jobs and the changes are non-breaking improvements.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify Docker image version and changes
# Check if v1.0.2 is the latest tag
gh api \
-H "Accept: application/vnd.github+json" \
repos/dojoengine/dojo/packages/container/dojo-dev/versions \
--jq 'map(select(.metadata.container.tags[] | contains("v1.0"))) | sort_by(.created_at) | reverse | .[0].metadata.container.tags'
# Check for changelog or release notes
gh api \
-H "Accept: application/vnd.github+json" \
repos/dojoengine/dojo/releases/tags/v1.0.2 \
--jq '.body'
Length of output: 2532
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2723 +/- ##
==========================================
+ Coverage 56.24% 56.25% +0.01%
==========================================
Files 415 415
Lines 53206 53206
==========================================
+ Hits 29927 29933 +6
+ Misses 23279 23273 -6 ☔ View full report in Codecov by Sentry. |
Co-authored-by: glihm <[email protected]>
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
Chores