chore(devcontainer): update image: ebcc23d #2728
Conversation
WalkthroughOhayo, sensei! This pull request primarily updates the Docker image version used in various configuration files related to a Rust development environment and CI workflows. The image reference has been changed from Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
.github/workflows/ci.yml (1)
Line range hint
184-201: Consider adding fee-enabled test scenariosThe new test-hurl job is a great addition for API testing! However, running Katana with
--dev.no-feemight miss potential fee-related issues.Consider adding another test scenario with fees enabled to ensure comprehensive coverage of real-world scenarios. Here's a suggested approach:
- nohup /tmp/bins/katana --dev --dev.accounts 2 --dev.no-fee & + # Run two scenarios: one with fees and one without + nohup /tmp/bins/katana --dev --dev.accounts 2 --dev.no-fee & + KATANA_PID=$! + hurl --test examples/rpc/**/*.hurl + kill $KATANA_PID + nohup /tmp/bins/katana --dev --dev.accounts 2 &🧰 Tools
🪛 actionlint (1.7.4)
32-32: label "ubuntu-latest-32-cores" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
36-36: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (4)
.devcontainer/devcontainer.json(1 hunks).github/workflows/bench.yml(2 hunks).github/workflows/ci.yml(7 hunks).github/workflows/release-dispatch.yml(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- .devcontainer/devcontainer.json
- .github/workflows/bench.yml
🔇 Additional comments (2)
.github/workflows/release-dispatch.yml (1)
17-17: Ohayo sensei! The image update looks good!
The change from a semantic version to a specific commit hash (ebcc23d) follows CI/CD best practices by ensuring exact reproducibility of the build environment.
Let's verify the image exists and is properly tagged:
.github/workflows/ci.yml (1)
Line range hint 13-21: Ohayo sensei! Excellent binary artifact management
The addition of binary artifact management is a great improvement that:
- Builds binaries once and reuses them across jobs
- Reduces overall CI execution time
- Ensures consistent binary versions across all tests
🧰 Tools
🪛 actionlint (1.7.4)
32-32: label "ubuntu-latest-32-cores" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
36-36: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
| @@ -31,7 +31,7 @@ jobs: | |||
| needs: ensure-docker | |||
| runs-on: ubuntu-latest-32-cores | |||
| container: | |||
| image: ghcr.io/dojoengine/dojo-dev:v1.0.2 | |||
| image: ghcr.io/dojoengine/dojo-dev:ebcc23d | |||
There was a problem hiding this comment.
💡 Codebase verification
Ohayo sensei! The Docker image tag exists but needs updating
The ebcc23d tag exists in the container registry but appears to be an older tag, as evidenced by its position in the chronological list of tags. The latest stable version is v1.0.2. Consider using the latest stable version instead of a commit hash for better version tracking and maintainability.
- Replace
ghcr.io/dojoengine/dojo-dev:ebcc23dwithghcr.io/dojoengine/dojo-dev:v1.0.2in the following files:.github/workflows/ci.yml(lines 34, 59, 126, 142, 157, 166, 175)
🔗 Analysis chain
Ohayo sensei! Verify the Docker image version change
The image version has been changed from a semantic version to a commit hash (ebcc23d) across multiple jobs. While this ensures precise version pinning, it might make version tracking less intuitive.
Also applies to: 59-59, 126-126, 142-142, 157-157, 166-166, 175-175
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify if the Docker image exists and is accessible
docker pull ghcr.io/dojoengine/dojo-dev:ebcc23d 2>/dev/null
if [ $? -eq 0 ]; then
echo "✓ Image exists and is accessible"
else
echo "✗ Image not found or not accessible"
fi
# Check image details
docker inspect ghcr.io/dojoengine/dojo-dev:ebcc23d 2>/dev/null | jq '.[0].Created'
Length of output: 223
Script:
#!/bin/bash
# Let's check the GitHub Container Registry for available tags
gh api \
-H "Accept: application/vnd.github+json" \
-H "X-GitHub-Api-Version: 2022-11-28" \
/orgs/dojoengine/packages/container/dojo-dev/versions --paginate | jq -r '.[].metadata.container.tags[]' 2>/dev/null
# Also check the workflow file history to see when this image tag was introduced
git log -p --no-merges -S "ghcr.io/dojoengine/dojo-dev:ebcc23d" -- .github/workflows/ci.yml
Length of output: 4939
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2728 +/- ##
==========================================
- Coverage 56.24% 56.23% -0.02%
==========================================
Files 415 415
Lines 53241 53241
==========================================
- Hits 29948 29941 -7
- Misses 23293 23300 +7 ☔ View full report in Codecov by Sentry. |
|
Not needed nothing has changed. Only the commit name. |
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
Improvements
Bug Fixes