Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(devcontainer): update image: v1.0.9 #2842

Merged
merged 1 commit into from
Dec 27, 2024
Merged

chore(devcontainer): update image: v1.0.9 #2842

merged 1 commit into from
Dec 27, 2024
+11 −11

Conversation

tarrencev
Copy link
Contributor

@tarrencev tarrencev commented Dec 23, 2024 •
edited by coderabbitai bot
Loading

Automated changes by create-pull-request GitHub action

Summary by CodeRabbit

  • New Features
    • Updated Docker image version to v1.0.9 for development and CI workflows, ensuring the latest environment is utilized.
  • Bug Fixes
    • Improved artifact management in the CI workflow by adding a step to download artifacts from previous jobs.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Dec 23, 2024

Walkthrough

Ohayo, sensei! This pull request focuses on updating the Docker image version from v1.0.8 to v1.0.9 across multiple configuration files. The changes are consistent across the development container configuration (.devcontainer/devcontainer.json) and several GitHub Actions workflow files (.github/workflows/bench.yml, .github/workflows/ci.yml, and .github/workflows/release-dispatch.yml). The update ensures all development and CI environments use the latest container image version.

Changes

File Change Summary
.devcontainer/devcontainer.json Updated Docker image from v1.0.8 to v1.0.9
.github/workflows/bench.yml Updated container image version for bench-katana and bench-sozo jobs
.github/workflows/ci.yml Updated Docker image version for multiple jobs including test, ensure-wasm, dojo-core-test, etc.
.github/workflows/release-dispatch.yml Updated Docker image version in propose-release job

Possibly related PRs

Suggested Reviewers

  • glihm
📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 04b5f02 and 8f00090.

📒 Files selected for processing (4)
  • .devcontainer/devcontainer.json (1 hunks)
  • .github/workflows/bench.yml (2 hunks)
  • .github/workflows/ci.yml (7 hunks)
  • .github/workflows/release-dispatch.yml (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • .devcontainer/devcontainer.json
  • .github/workflows/release-dispatch.yml
🔇 Additional comments (2)
.github/workflows/bench.yml (1)

17-17: Ohayo! Version update looks consistent, sensei! 🎋

The Docker image version has been consistently updated to v1.0.9 across both benchmark jobs. The changes maintain workflow consistency.

Let's verify the image availability and changelog:

Also applies to: 39-39

✅ Verification successful

Ohayo! Docker image v1.0.9 is verified and ready for action, sensei! 🎋

The image ghcr.io/dojoengine/dojo-dev:v1.0.9 exists and was published on December 23, 2024. It's also tagged as latest, indicating it's the most recent stable release.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the Docker image exists and check its creation date
gh api \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  /orgs/dojoengine/packages/container/dojo-dev/versions \
  | jq '.[] | select(.metadata.container.tags[] == "v1.0.9")'

Length of output: 810

.github/workflows/ci.yml (1)

34-34: Version consistency maintained across all CI jobs, sensei! 🍜

The Docker image version has been systematically updated to v1.0.9 across all CI jobs. The changes maintain consistency with the benchmark workflow.

Let's verify version consistency across all workflow files:

Also applies to: 59-59, 126-126, 142-142, 157-157, 166-166, 175-175

✅ Verification successful

Ohayo! All workflow files are in perfect harmony with v1.0.9, sensei! 🍜

The verification confirms consistent version usage across all workflow files:

  • ci.yml: All jobs using v1.0.9
  • bench.yml: Both instances using v1.0.9
  • release-dispatch.yml: Using v1.0.9
  • devcontainer.yml: Properly configured to handle version updates dynamically
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for any missed version updates or inconsistencies
rg -g '*.yml' -g '*.json' "ghcr.io/dojoengine/dojo-dev:" .github/workflows/

Length of output: 1220

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov Codecov
Copy link

codecov bot commented Dec 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.14%. Comparing base (04b5f02) to head (8f00090).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2842   +/-   ##
=======================================
  Coverage   56.14%   56.14%           
=======================================
  Files         440      440           
  Lines       56662    56662           
=======================================
  Hits        31814    31814           
  Misses      24848    24848

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm merged commit 1c3ff08 into main Dec 27, 2024
14 checks passed
@glihm glihm deleted the bump-devcontainer branch December 27, 2024 18:50
This was referenced Jan 2, 2025
Merged
Merged
Closed
Merged
Merged
Merged
Merged
This was referenced Jan 10, 2025
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glihm glihm glihm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarrencev @glihm