refactor(torii-grpc): empty hashed keys in subscription match all entities

[Larkooo]

Summary by CodeRabbit

• Bug Fixes
  • Improved stability by adding a condition to verify that hashed_keys is not empty before checking for specific keys.

[coderabbitai]

Walkthrough

The recent changes optimized internal logic within the Service implementation of the entity.rs and event_message.rs files in the torii/grpc/src/server/subscriptions module. The main update ensures that the hashed_keys collection is checked for non-emptiness before verifying the presence of specific keys, improving the robustness and reliability of the key-checking mechanisms.

Changes

Files	Change Summary
crates/torii/grpc/src/server/subscriptions/entity.rs	Updated Service implementation to check if hashed_keys is not empty before checking for a specific hashed key.
crates/torii/grpc/src/server/subscriptions/event_message.rs	Added a condition in Service implementation to ensure hashed_keys is not empty before verifying key containment.

Poem

In Torii's quiet coding den,
Changes fluttered once again,
Keys now checked with wiser eyes,
Looking first if hashed_keys rise.
Robustness grew with each new line,
Making code more sure, more fine. 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2e04f54 and a76e56f.

Files selected for processing (2)

• crates/torii/grpc/src/server/subscriptions/entity.rs (1 hunks)
• crates/torii/grpc/src/server/subscriptions/event_message.rs (1 hunks)

Files skipped from review due to trivial changes (1)

• crates/torii/grpc/src/server/subscriptions/entity.rs

Additional comments not posted (1)

crates/torii/grpc/src/server/subscriptions/event_message.rs (1)

111-111: LGTM! The added condition improves control flow and prevents potential errors.

The added condition to check if the hashed_keys collection is not empty before verifying the presence of a specific hashed key optimizes the control flow and prevents potential errors related to empty collections.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.74%. Comparing base (2e04f54) to head (a76e56f).
Report is 1 commits behind head on main.

Files	Patch %	Lines
...ates/torii/grpc/src/server/subscriptions/entity.rs	0.00%	1 Missing ⚠️
...rii/grpc/src/server/subscriptions/event_message.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2154      +/-   ##
==========================================
- Coverage   67.75%   67.74%   -0.01%     
==========================================
  Files         336      336              
  Lines       43152    43152              
==========================================
- Hits        29237    29234       -3     
- Misses      13915    13918       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.