bump `account_sdk` to rev `199d87d` on main #2165

kariy · 2024-07-09T13:44:28Z

Summary by CodeRabbit

Chores
- Updated dependencies to specific revisions for account_sdk and slot for more stable builds.

coderabbitai · 2024-07-09T13:44:36Z

Walkthrough

The recent changes to Cargo.toml involve updating the versions of key dependencies, account_sdk and slot. The dependencies no longer pull from branches but are now fixed at specific revisions. This ensures consistency in dependency versions, aiding in maintaining stable builds and facilitating pinpoint debugging.

Changes

File	Change Summary
`Cargo.toml`	Updated `account_sdk` from branch "bump-starknet" to revision "199d87d". Updated `slot` from revision "4c1165d" to "199d87d".

Poem

By the code's revision, we take a dive,
Locking versions to keep our software alive.
Consistency in builds, so stable, so true,
Ensuring our project shines, like morning dew.
Revisions set in stone, a coder's delight,
Let's raise a toast to dependences right! 🥂

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 37ccead and 9563792.

Files ignored due to path filters (1)

Cargo.lock is excluded by !**/*.lock

Files selected for processing (1)

Cargo.toml (2 hunks)

Additional comments not posted (2)

Cargo.toml (2)

228-228: Approved: Updated account_sdk to a specific revision.

Switching from a branch-based to a revision-specific reference enhances stability and reproducibility.

229-229: Approved: Updated slot to a consistent revision.

Aligning the slot dependency with the same revision as account_sdk ensures consistency across dependencies.

glihm · 2024-07-09T14:08:11Z

Cargo.toml

@@ -225,7 +225,7 @@ alloy-sol-types = { version = "0.7.6", default-features = false }
 criterion = "0.5.1"

 # Controller integration
-account_sdk = { git = "https://github.com/cartridge-gg/controller", branch = "bump-starknet" }
+account_sdk = { git = "https://github.com/cartridge-gg/controller", rev = "199d87d" }


Do we want a tag for this more stable revision instead of a rev? Or not enough for a tag? (On the account sdk side)

not exactly sure for now but i think definitely should tag it

codecov · 2024-07-09T14:11:38Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.99%. Comparing base (37ccead) to head (9563792).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2165   +/-   ##
=======================================
  Coverage   67.99%   67.99%           
=======================================
  Files         331      331           
  Lines       42686    42686           
=======================================
  Hits        29024    29024           
  Misses      13662    13662

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bump account_sdk to latest main

9563792

coderabbitai bot reviewed Jul 9, 2024

View reviewed changes

glihm approved these changes Jul 9, 2024

View reviewed changes

kariy changed the title ~~bump account_sdk to rev 199d87d on main'~~ bump account_sdk to rev 199d87d on main Jul 9, 2024

kariy merged commit ba1c0e4 into main Jul 9, 2024
15 checks passed

kariy deleted the bump-account-sdk branch July 9, 2024 14:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump `account_sdk` to rev `199d87d` on main #2165

bump `account_sdk` to rev `199d87d` on main #2165

kariy commented Jul 9, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 9, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

glihm Jul 9, 2024

kariy Jul 9, 2024

codecov bot commented Jul 9, 2024

bump account_sdk to rev 199d87d on main #2165

bump account_sdk to rev 199d87d on main #2165

Conversation

kariy commented Jul 9, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Jul 9, 2024 • edited Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

glihm Jul 9, 2024

Choose a reason for hiding this comment

kariy Jul 9, 2024

Choose a reason for hiding this comment

codecov bot commented Jul 9, 2024

Codecov Report

bump `account_sdk` to rev `199d87d` on main #2165

bump `account_sdk` to rev `199d87d` on main #2165

kariy commented Jul 9, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 9, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)