Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(torii-grpc): empty hashed keys in subscription match all entities #2154

Merged
merged 1 commit into from
Jul 8, 2024
Merged

refactor(torii-grpc): empty hashed keys in subscription match all entities #2154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/torii/grpc/src/server/subscriptions/entity.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
// matches the key pattern of the subscriber.
match &sub.keys {
Some(EntityKeysClause::HashedKeys(hashed_keys)) => {
if !hashed_keys.contains(&hashed) {
if !hashed_keys.is_empty() && !hashed_keys.contains(&hashed) {

Check warning on line 112 in crates/torii/grpc/src/server/subscriptions/entity.rs

View check run for this annotation

Codecov / codecov/patch

crates/torii/grpc/src/server/subscriptions/entity.rs#L112 

Added line #L112 was not covered by tests
continue;
}
}
Expand Down
2 changes: 1 addition & 1 deletion crates/torii/grpc/src/server/subscriptions/event_message.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
// matches the key pattern of the subscriber.
match &sub.keys {
Some(EntityKeysClause::HashedKeys(hashed_keys)) => {
if !hashed_keys.contains(&hashed) {
if !hashed_keys.is_empty() && !hashed_keys.contains(&hashed) {

Check warning on line 111 in crates/torii/grpc/src/server/subscriptions/event_message.rs

View check run for this annotation

Codecov / codecov/patch

crates/torii/grpc/src/server/subscriptions/event_message.rs#L111 

Added line #L111 was not covered by tests
continue;
}
}
Expand Down
Loading