Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor forked provider backend APIs #1944

Merged
merged 7 commits into from
May 9, 2024
Merged

Refactor forked provider backend APIs #1944

merged 7 commits into from
May 9, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented May 8, 2024

Description

Related issue

Tests

  • Yes
  • No, because they aren't needed
  • No, because I need help

Added to documentation?

  • README.md
  • Dojo Book
  • No documentation needed

Checklist

  • I've formatted my code (scripts/prettier.sh, scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
  • I've linted my code (scripts/clippy.sh, scripts/docs.sh)
  • I've commented my code
  • I've requested a review after addressing the comments

@kariy
Copy link
Member Author

kariy commented May 8, 2024

@kariy kariy changed the title refactor forked backend apis Simplify May 8, 2024
@kariy kariy changed the title Simplify refactor(katana): simplify forked backend api May 8, 2024
@kariy kariy changed the title refactor(katana): simplify forked backend api Refactor forked provider backend APIs May 8, 2024
@kariy kariy marked this pull request as ready for review May 8, 2024 21:55
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 89.51965% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 69.61%. Comparing base (5a7ecd8) to head (9483796).
Report is 1 commits behind head on main.

❗ Current head 9483796 differs from pull request most recent head 8a99d3d. Consider uploading reports for the commit 8a99d3d to get more accurate results

Files Patch % Lines
...ana/storage/provider/src/providers/fork/backend.rs 89.23% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1944      +/-   ##
==========================================
+ Coverage   69.38%   69.61%   +0.23%     
==========================================
  Files         314      314              
  Lines       35391    35368      -23     
==========================================
+ Hits        24555    24621      +66     
+ Misses      10836    10747      -89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy
Copy link
Member Author

kariy commented May 9, 2024

Merge activity

  • May 9, 4:27 PM EDT: @kariy started a stack merge that includes this pull request via Graphite.
  • May 9, 4:28 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 9, 4:29 PM EDT: @kariy merged this pull request with Graphite.

Base automatically changed from refactor/remove-contract-info-provider to main May 9, 2024 20:27
@kariy kariy force-pushed the refactor/forked-backend branch from 9483796 to 8a99d3d Compare May 9, 2024 20:28
@kariy kariy merged commit 7194fb9 into main May 9, 2024
11 checks passed
@kariy kariy deleted the refactor/forked-backend branch May 9, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant