chore(katana): ignore forked backend thread spawn test #1977
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ignore test that checks if the backend thread is spawned or not, for now, as we have made sure (since #1944) that the thread will always be spawned when creating a new
Backend
:dojo/crates/katana/storage/provider/src/providers/fork/backend.rs
Lines 140 to 157 in 628542f
currently the test is passing due to an error that was not being expected from the test. what the test was meant to do is to test that an error should happen if the
BackendHandle
is being used while theBackend
is nonexistant/dropped.but because the recent refactor in #1944, the end goal is to separate the thread spawning entirely out of the creation of the
Backend
. so that we can let the api consumer to handle how to drive theBackend
future forward.Related issue
Tests
Added to documentation?
Checklist
scripts/prettier.sh
,scripts/rust_fmt.sh
,scripts/cairo_fmt.sh
)scripts/clippy.sh
,scripts/docs.sh
)