Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(katana): ensure contract non-existent is validated properly on StateProvider::nonce() of forked provider #1947

Merged
merged 4 commits into from
May 9, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented May 9, 2024

Description

Related issue

Tests

  • Yes
  • No, because they aren't needed
  • No, because I need help

Added to documentation?

  • README.md
  • Dojo Book
  • No documentation needed

Checklist

  • I've formatted my code (scripts/prettier.sh, scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
  • I've linted my code (scripts/clippy.sh, scripts/docs.sh)
  • I've commented my code
  • I've requested a review after addressing the comments

@kariy
Copy link
Member Author

kariy commented May 9, 2024

@kariy kariy changed the title wip test(katana): May 9, 2024
@kariy kariy mentioned this pull request May 9, 2024
10 tasks
@kariy kariy changed the title test(katana): test(katana): unit tests for forked nonce May 9, 2024
@kariy kariy marked this pull request as ready for review May 9, 2024 19:52
@kariy kariy changed the title test(katana): unit tests for forked nonce test(katana): ensure contract non-existent is validated properly on StateProvider::nonce() of forked provider May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 92.61538% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 69.69%. Comparing base (5a7ecd8) to head (56d0be6).
Report is 2 commits behind head on main.

❗ Current head 56d0be6 differs from pull request most recent head bad473f. Consider uploading reports for the commit bad473f to get more accurate results

Files Patch % Lines
...ana/storage/provider/src/providers/fork/backend.rs 88.99% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1947      +/-   ##
==========================================
+ Coverage   69.38%   69.69%   +0.31%     
==========================================
  Files         314      314              
  Lines       35391    35459      +68     
==========================================
+ Hits        24555    24714     +159     
+ Misses      10836    10745      -91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy
Copy link
Member Author

kariy commented May 9, 2024

Merge activity

  • May 9, 4:27 PM EDT: @kariy started a stack merge that includes this pull request via Graphite.
  • May 9, 4:30 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 9, 4:31 PM EDT: @kariy merged this pull request with Graphite.

@kariy kariy force-pushed the refactor/forked-backend branch from 9483796 to 8a99d3d Compare May 9, 2024 20:28
Base automatically changed from refactor/forked-backend to main May 9, 2024 20:29
@kariy kariy force-pushed the fix/forked-state branch from 56d0be6 to bad473f Compare May 9, 2024 20:30
@kariy kariy merged commit 6dca944 into main May 9, 2024
11 checks passed
@kariy kariy deleted the fix/forked-state branch May 9, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant