Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(katana-db): add new db methods #1838

Closed
wants to merge 5 commits into from
Closed

Conversation

kariy
Copy link
Member

@kariy kariy commented Apr 15, 2024

add some new methods to the database:

  • view: basically similar to update but for read-only tx
  • drop_table: for dropping a table from the database

@kariy
Copy link
Member Author

kariy commented Apr 15, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kariy and the rest of your teammates on Graphite Graphite

@kariy kariy changed the title add drop table method feat(katana-db): drop table method Apr 15, 2024
@kariy kariy marked this pull request as ready for review April 15, 2024 17:09
@kariy kariy force-pushed the older-table-version branch from 3a26ffe to 7ae29da Compare April 15, 2024 17:13
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 61.95652% with 70 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (older-table-version@ae94503). Click here to learn what that means.

❗ Current head 06a9eb9 differs from pull request most recent head 2691e99. Consider uploading reports for the commit 2691e99 to get more accurate results

Files Patch % Lines
crates/katana/storage/db/src/mdbx/tx.rs 60.86% 18 Missing ⚠️
crates/katana/storage/db/src/tables/mod.rs 48.27% 15 Missing ⚠️
crates/katana/storage/db/src/mdbx/mod.rs 50.00% 14 Missing ⚠️
crates/katana/storage/db/src/tables/v0.rs 0.00% 13 Missing ⚠️
crates/katana/storage/db/src/lib.rs 50.00% 8 Missing ⚠️
crates/katana/storage/db/src/codecs/postcard.rs 0.00% 1 Missing ⚠️
crates/katana/storage/db/src/error.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##             older-table-version    #1838   +/-   ##
======================================================
  Coverage                       ?   70.32%           
======================================================
  Files                          ?      311           
  Lines                          ?    35166           
  Branches                       ?        0           
======================================================
  Hits                           ?    24729           
  Misses                         ?    10437           
  Partials                       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy kariy force-pushed the older-table-version branch from 7ae29da to 61e11a7 Compare April 16, 2024 06:40
@kariy kariy force-pushed the older-table-version branch from 61e11a7 to 5ab5bb5 Compare April 16, 2024 10:01
@kariy kariy force-pushed the drop-table branch 3 times, most recently from 390328a to 253df01 Compare April 16, 2024 20:03
@kariy kariy force-pushed the older-table-version branch from 00509d5 to ec3252d Compare April 16, 2024 20:04
@kariy kariy changed the title feat(katana-db): drop table method feat(katana-db): add new db methods Apr 16, 2024
@kariy kariy force-pushed the older-table-version branch from ec3252d to 0f0043f Compare April 18, 2024 04:38
@glihm glihm added the katana This issue is related to Katana label Apr 19, 2024
@kariy kariy force-pushed the older-table-version branch from 0f0043f to ae94503 Compare April 24, 2024 04:09
@kariy kariy closed this Apr 26, 2024
@kariy kariy deleted the drop-table branch July 23, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
katana This issue is related to Katana
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants