Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(katana-db): database schema #1837

Closed
wants to merge 13 commits into from
Closed

refactor(katana-db): database schema #1837

wants to merge 13 commits into from

Conversation

kariy
Copy link
Member

@kariy kariy commented Apr 15, 2024

  • refactor database tables to be based on a 'schema'
  • added Schema trait to define database schema; basically a collection of tables that will be created in the database
  • use schema to create a notion of database 'versioning'

@kariy
Copy link
Member Author

kariy commented Apr 15, 2024

@kariy kariy changed the title tables of older database version katana: versioned the database tables Apr 15, 2024
@kariy kariy marked this pull request as ready for review April 15, 2024 17:08
@kariy kariy force-pushed the bump-db-version branch from 0dd1a14 to d0edc74 Compare April 15, 2024 17:13
@kariy kariy force-pushed the older-table-version branch from 3a26ffe to 7ae29da Compare April 15, 2024 17:13
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 60.38961% with 61 lines in your changes are missing coverage. Please review.

Project coverage is 70.30%. Comparing base (77df165) to head (0f0043f).

❗ Current head 0f0043f differs from pull request most recent head ae94503. Consider uploading reports for the commit ae94503 to get more accurate results

Files Patch % Lines
crates/katana/storage/db/src/mdbx/tx.rs 29.62% 19 Missing ⚠️
crates/katana/storage/db/src/tables/mod.rs 48.27% 15 Missing ⚠️
crates/katana/storage/db/src/tables/v0.rs 0.00% 13 Missing ⚠️
crates/katana/storage/db/src/lib.rs 50.00% 8 Missing ⚠️
crates/katana/storage/db/src/mdbx/mod.rs 72.22% 5 Missing ⚠️
crates/katana/storage/db/src/codecs/postcard.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1837      +/-   ##
==========================================
+ Coverage   70.28%   70.30%   +0.02%     
==========================================
  Files         313      311       -2     
  Lines       35729    35137     -592     
==========================================
- Hits        25111    24703     -408     
+ Misses      10618    10434     -184     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy kariy force-pushed the bump-db-version branch from d0edc74 to 4263600 Compare April 16, 2024 06:39
@kariy kariy force-pushed the older-table-version branch from 7ae29da to 61e11a7 Compare April 16, 2024 06:40
@kariy kariy force-pushed the bump-db-version branch from 4263600 to 6d77829 Compare April 16, 2024 10:01
@kariy kariy force-pushed the older-table-version branch from 61e11a7 to 5ab5bb5 Compare April 16, 2024 10:01
@kariy kariy force-pushed the bump-db-version branch from 6d77829 to 549ba28 Compare April 16, 2024 20:04
@kariy kariy force-pushed the older-table-version branch from 00509d5 to ec3252d Compare April 16, 2024 20:04
@kariy kariy changed the title katana: versioned the database tables refactor(katana-db): database schema Apr 16, 2024
@kariy kariy force-pushed the bump-db-version branch from 549ba28 to b4bb0b2 Compare April 18, 2024 04:38
@kariy kariy force-pushed the older-table-version branch from ec3252d to 0f0043f Compare April 18, 2024 04:38
@glihm glihm added the katana This issue is related to Katana label Apr 19, 2024
Base automatically changed from bump-db-version to main April 24, 2024 01:57
@kariy kariy force-pushed the older-table-version branch from 0f0043f to ae94503 Compare April 24, 2024 04:09
@kariy kariy closed this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
katana This issue is related to Katana
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants