-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump katana
database version
#1833
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1833 +/- ##
=======================================
Coverage 70.51% 70.52%
=======================================
Files 309 309
Lines 35024 35029 +5
=======================================
+ Hits 24698 24705 +7
+ Misses 10326 10324 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to have this versioning. 👍
So the migration work will be to support 0
-> 1
automatically?
Do we want semver versioning here? Or a simple digit is enough?
at least for 0 -> 1, yes it will be done automatically if you're creating katana using older db version.
simple digit is more convenient as we want to only bump it if there are breaking changes to the schema. changes that do not break schema are irrelevant in the migration process. |
6d77829
to
549ba28
Compare
bump database version to
1
for the next release due to breaking changes introduced in #1773, #1774, #1775