Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump katana database version #1833

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Bump katana database version #1833

merged 2 commits into from
Apr 24, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Apr 15, 2024

bump database version to 1 for the next release due to breaking changes introduced in #1773, #1774, #1775

@kariy
Copy link
Member Author

kariy commented Apr 15, 2024

@kariy kariy changed the title bump db version Bump katana database version Apr 15, 2024
@kariy kariy marked this pull request as ready for review April 15, 2024 12:44
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.52%. Comparing base (9c47ba7) to head (b4bb0b2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1833   +/-   ##
=======================================
  Coverage   70.51%   70.52%           
=======================================
  Files         309      309           
  Lines       35024    35029    +5     
=======================================
+ Hits        24698    24705    +7     
+ Misses      10326    10324    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm added the katana This issue is related to Katana label Apr 15, 2024
Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to have this versioning. 👍

So the migration work will be to support 0 -> 1 automatically?
Do we want semver versioning here? Or a simple digit is enough?

@kariy
Copy link
Member Author

kariy commented Apr 15, 2024

So the migration work will be to support 0 -> 1 automatically?

at least for 0 -> 1, yes it will be done automatically if you're creating katana using older db version.

Do we want semver versioning here? Or a simple digit is enough?

simple digit is more convenient as we want to only bump it if there are breaking changes to the schema. changes that do not break schema are irrelevant in the migration process.

@kariy kariy force-pushed the bump-db-version branch 3 times, most recently from 6d77829 to 549ba28 Compare April 16, 2024 20:04
@kariy kariy force-pushed the bump-db-version branch from 549ba28 to b4bb0b2 Compare April 18, 2024 04:38
@kariy kariy merged commit 77df165 into main Apr 24, 2024
22 checks passed
@kariy kariy deleted the bump-db-version branch April 24, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
katana This issue is related to Katana
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants