Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DR | Remove unused prefills #20199

Merged
merged 2 commits into from
Jan 10, 2025
Merged

DR | Remove unused prefills #20199

merged 2 commits into from
Jan 10, 2025

Conversation

Mottie
Copy link
Contributor

@Mottie Mottie commented Jan 9, 2025

Summary

  • This work is behind a feature toggle (flipper): YES/NO

    NO

  • (Summarize the changes that have been made to the platform)

    We're removing prefill data that isn't being used by our Decision Review forms.

  • (If bug, how to reproduce)
  • (What is the solution, why is this the solution?)
  • (Which team do you work for, does your team own the maintenance of this component?)

    Benefits Decision Reviews

  • (If introducing a flipper, what is the success criteria being targeted?)

Related issue(s)

department-of-veterans-affairs/va.gov-team#99077

Testing done

N/A

Screenshots

N/A

What areas of the site does it impact?

Decision Reviews forms: Higher-Level Review (0996) and Notice of Disagreement (10182)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@Mottie Mottie added NOD Notice of Disagreement (Decision Reviews) HLR Higher Level Reviews (Decision Reviews) labels Jan 9, 2025
@Mottie Mottie self-assigned this Jan 9, 2025
shaunburdick
shaunburdick previously approved these changes Jan 9, 2025
Copy link
Contributor

@shaunburdick shaunburdick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@va-vfs-bot va-vfs-bot temporarily deployed to 99077-remove-unused-prefill/main/main January 9, 2025 19:43 Inactive
@Mottie Mottie marked this pull request as ready for review January 9, 2025 20:07
@Mottie Mottie requested review from a team as code owners January 9, 2025 20:07
@LindseySaari
Copy link
Contributor

It looks like you've got some failing specs associated with these changes

@Mottie Mottie merged commit 50c6a32 into master Jan 10, 2025
26 checks passed
@Mottie Mottie deleted the 99077-remove-unused-prefill branch January 10, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HLR Higher Level Reviews (Decision Reviews) NOD Notice of Disagreement (Decision Reviews) require-backend-approval test-passing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2025 Q1 Support Tracker
4 participants