Skip to content

Commit

Permalink
DR | Remove unused prefills (#20199)
Browse files Browse the repository at this point in the history
* Remove unused DR prefills

* Fix prefill tests
  • Loading branch information
Mottie authored Jan 10, 2025
1 parent c808389 commit 50c6a32
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 80 deletions.
16 changes: 0 additions & 16 deletions config/form_profile_mappings/10182.yml
Original file line number Diff line number Diff line change
@@ -1,19 +1,3 @@
data:
attributes:
veteran:
address:
addressLine1: [contact_information, address, street]
addressLine2: [contact_information, address, street2]
addressLine3: [street3]
city: [contact_information, address, city]
stateCode: [contact_information, address, state]
zipCode5: [contact_information, address, postal_code]
countryName: [contact_information, address, country]
internationalPostalCode: [vet360_mailing_address, international_postal_code]
phone:
areaCode: [phone_object, area_code]
phoneNumber: [phone_object, phone_number]
emailAddressText: [contact_information, email]
nonPrefill:
veteranSsnLastFour: [identity_information, ssn_last_four]
veteranVaFileNumberLastFour: [va_file_number_last_four]
17 changes: 0 additions & 17 deletions config/form_profile_mappings/20-0996.yml
Original file line number Diff line number Diff line change
@@ -1,20 +1,3 @@
data:
attributes:
veteran:
address:
zipCode5: [contact_information, address, postal_code]
phone:
areaCode: [phone_object, area_code]
phoneNumber: [phone_object, phone_number]
emailAddressText: [contact_information, email]
nonPrefill:
veteranAddress:
street: [contact_information, address, street]
street2: [contact_information, address, street2]
street3: [street3]
city: [contact_information, address, city]
state: [contact_information, address, state]
country: [contact_information, address, country]
postalCode: [contact_information, address, postal_code]
veteranSsnLastFour: [identity_information, ssn_last_four]
veteranVaFileNumberLastFour: [va_file_number_last_four]
24 changes: 0 additions & 24 deletions spec/models/form_profile_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -1958,16 +1958,6 @@ def expect_prefilled(form_id)
end

it 'prefills' do
expect(prefill.dig('data', 'attributes', 'veteran', 'address', 'zipCode5')).to be_a(String).or be_nil
expect(prefill.dig('data', 'attributes', 'veteran', 'phone', 'areaCode')).to be_a(String).or be_nil
expect(prefill.dig('data', 'attributes', 'veteran', 'phone', 'phoneNumber')).to be_a(String).or be_nil
expect(prefill.dig('nonPrefill', 'veteranAddress', 'street')).to be_a(String).or be_nil
expect(prefill.dig('nonPrefill', 'veteranAddress', 'street2')).to be_a(String).or be_nil
expect(prefill.dig('nonPrefill', 'veteranAddress', 'street3')).to be_a(String).or be_nil
expect(prefill.dig('nonPrefill', 'veteranAddress', 'city')).to be_a(String).or be_nil
expect(prefill.dig('nonPrefill', 'veteranAddress', 'state')).to be_a(String).or be_nil
expect(prefill.dig('nonPrefill', 'veteranAddress', 'country')).to be_a(String).or be_nil
expect(prefill.dig('nonPrefill', 'veteranAddress', 'postalCode')).to be_a(String).or be_nil
expect(prefill.dig('nonPrefill', 'veteranSsnLastFour')).to be_a(String).or be_nil
expect(prefill.dig('nonPrefill', 'veteranVaFileNumberLastFour')).to be_a(String)
end
Expand Down Expand Up @@ -2007,20 +1997,6 @@ def expect_prefilled(form_id)
end

it 'prefills' do
veteran = prefill.dig 'data', 'attributes', 'veteran'
address = veteran['address']
phone = veteran['phone']
expect(address['addressLine1']).to be_a String
expect(address['addressLine2']).to be_a(String).or be_nil
expect(address['addressLine3']).to be_a(String).or be_nil
expect(address['city']).to be_a String
expect(address['stateCode']).to be_a String
expect(address['zipCode5']).to be_a String
expect(address['countryName']).to be_a String
expect(address['internationalPostalCode']).to be_a(String).or be_nil
expect(phone['areaCode']).to be_a String
expect(phone['phoneNumber']).to be_a String
expect(veteran['emailAddressText']).to be_a String
non_prefill = prefill['nonPrefill']
expect(non_prefill['veteranSsnLastFour']).to be_a String
expect(non_prefill['veteranVaFileNumberLastFour']).to be_a String
Expand Down
23 changes: 0 additions & 23 deletions spec/models/form_profile_v2_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -1623,16 +1623,6 @@ def expect_prefilled(form_id)
end

it 'prefills' do
expect(prefill.dig('data', 'attributes', 'veteran', 'address', 'zipCode5')).to be_a(String).or be_nil
expect(prefill.dig('data', 'attributes', 'veteran', 'phone', 'areaCode')).to be_a(String).or be_nil
expect(prefill.dig('data', 'attributes', 'veteran', 'phone', 'phoneNumber')).to be_a(String).or be_nil
expect(prefill.dig('nonPrefill', 'veteranAddress', 'street')).to be_a(String).or be_nil
expect(prefill.dig('nonPrefill', 'veteranAddress', 'street2')).to be_a(String).or be_nil
expect(prefill.dig('nonPrefill', 'veteranAddress', 'street3')).to be_a(String).or be_nil
expect(prefill.dig('nonPrefill', 'veteranAddress', 'city')).to be_a(String).or be_nil
expect(prefill.dig('nonPrefill', 'veteranAddress', 'state')).to be_a(String).or be_nil
expect(prefill.dig('nonPrefill', 'veteranAddress', 'country')).to be_a(String).or be_nil
expect(prefill.dig('nonPrefill', 'veteranAddress', 'postalCode')).to be_a(String).or be_nil
expect(prefill.dig('nonPrefill', 'veteranSsnLastFour')).to be_a(String).or be_nil
expect(prefill.dig('nonPrefill', 'veteranVaFileNumberLastFour')).to be_a(String)
end
Expand Down Expand Up @@ -1672,19 +1662,6 @@ def expect_prefilled(form_id)
end

it 'prefills' do
veteran = prefill.dig 'data', 'attributes', 'veteran'
address = veteran['address']
phone = veteran['phone']
expect(address['addressLine1']).to be_a String
expect(address['addressLine2']).to be_a(String).or be_nil
expect(address['city']).to be_a String
expect(address['stateCode']).to be_a String
expect(address['zipCode5']).to be_a String
expect(address['countryName']).to be_a String
expect(address['internationalPostalCode']).to be_a(String).or be_nil
expect(phone['areaCode']).to be_a String
expect(phone['phoneNumber']).to be_a String
expect(veteran['emailAddressText']).to be_a String
non_prefill = prefill['nonPrefill']
expect(non_prefill['veteranSsnLastFour']).to be_a String
expect(non_prefill['veteranVaFileNumberLastFour']).to be_a String
Expand Down

0 comments on commit 50c6a32

Please sign in to comment.