-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bdex/80773: Toxic Exposure - [Lighthouse API] generatePdf hook up #16411
Conversation
…neratePDF endpoint
…neratePDF endpoint
…neratePDF endpoint
@@ -13,7 +13,7 @@ module BenefitsClaims | |||
class Configuration < Common::Client::Configuration::REST | |||
self.read_timeout = Settings.lighthouse.benefits_claims.timeout || 20 | |||
|
|||
API_SCOPES = %w[system/claim.read system/claim.write].freeze | |||
API_SCOPES = %w[system/claim.read system/claim.write system/526-pdf.override].freeze |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verified that staging and production Lighthouse benefits claims client ids can generate an auth token with these scopes listed
references: https://dsva.slack.com/archives/C02CQP3RFFX/p1713469011121339
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Approved!
@aurora-a-k-a-lightning are there any tests in |
@rmtolmach ah yes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Summary
Related issue(s)
Testing done
Yes
Screenshots
Note: Optional
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?