Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bdex/80773: Toxic Exposure - [Lighthouse API] generatePdf hook up #16411

Merged
merged 10 commits into from
Apr 23, 2024

Conversation

aurora-a-k-a-lightning
Copy link
Contributor

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

  • This work is behind a feature toggle (flipper): YES
  • enable benefits_claims/service#submit526 to call LH's /generatePDF endpoint

Related issue(s)

  • #80773

Testing done

Yes

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@@ -13,7 +13,7 @@ module BenefitsClaims
class Configuration < Common::Client::Configuration::REST
self.read_timeout = Settings.lighthouse.benefits_claims.timeout || 20

API_SCOPES = %w[system/claim.read system/claim.write].freeze
API_SCOPES = %w[system/claim.read system/claim.write system/526-pdf.override].freeze
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified that staging and production Lighthouse benefits claims client ids can generate an auth token with these scopes listed
references: https://dsva.slack.com/archives/C02CQP3RFFX/p1713469011121339

@va-vfs-bot va-vfs-bot temporarily deployed to bdex/80773/main/main April 22, 2024 22:04 Inactive
@aurora-a-k-a-lightning aurora-a-k-a-lightning marked this pull request as ready for review April 22, 2024 23:14
@aurora-a-k-a-lightning aurora-a-k-a-lightning requested a review from a team as a code owner April 22, 2024 23:14
sethdarragile6
sethdarragile6 previously approved these changes Apr 22, 2024
Copy link
Contributor

@sethdarragile6 sethdarragile6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Approved!

@rmtolmach
Copy link
Contributor

@aurora-a-k-a-lightning are there any tests in spec/lib/lighthouse/benefits_claims/service_spec.rb that can be updated to go along with your code changes?

@aurora-a-k-a-lightning
Copy link
Contributor Author

@rmtolmach ah yes :)
there is a test now.
thank you!

Copy link
Contributor

@rmtolmach rmtolmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants