Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Backup Submission Flow 526 Lighthouse Submissions #82245

Closed
5 tasks
tblackwe opened this issue May 3, 2024 · 5 comments
Closed
5 tasks

Implement Backup Submission Flow 526 Lighthouse Submissions #82245

tblackwe opened this issue May 3, 2024 · 5 comments
Assignees
Labels
DBEX-Carbs Disability Benefits Experience - Team Carbs disability-experience

Comments

@tblackwe
Copy link
Contributor

tblackwe commented May 3, 2024

Issue Description

When 526 is cutover from using EVSS to Lighthouse APIs, our current mechanism for generating a PDF in backup submissions will no longer function. The Backup submission needs to implement an alternate path based on the Primary submission target API


Tasks

Acceptance Criteria

  • Backup submission updated to support diverging PDF generation
  • 100% Passing spec tests
  • 90% testing line coverage of new code

Breadcrumbs:

@tblackwe tblackwe added the DBEX-Carbs Disability Benefits Experience - Team Carbs label May 3, 2024
@SamStuckey
Copy link
Contributor

It looks like the flipper logic is all in place in the backup submission processor. I think all we need to do here is implement the logic you've linked above in this API provider factory. TL;DR @aurora-a-k-a-lightning did the hard stuff, we just need to flesh out the API provider and test.

@tblackwe
Copy link
Contributor Author

tblackwe commented May 3, 2024

nice. ty for the analysis Sam

@SamStuckey
Copy link
Contributor

WIP DRAFT PR:
department-of-veterans-affairs/vets-api#16876

@SamStuckey
Copy link
Contributor

HAND OFF: @tblackwe is taking this over due to an increased code yellow work load

@SamStuckey
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DBEX-Carbs Disability Benefits Experience - Team Carbs disability-experience
Projects
None yet
Development

No branches or pull requests

4 participants