Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toxic Exposure - [Lighthouse API] generatePdf hook up #80773

Closed
2 of 10 tasks
aurora-a-k-a-lightning opened this issue Apr 15, 2024 · 1 comment
Closed
2 of 10 tasks

Toxic Exposure - [Lighthouse API] generatePdf hook up #80773

aurora-a-k-a-lightning opened this issue Apr 15, 2024 · 1 comment
Assignees
Labels
backend DBEX-TREX Disability Benefits Experience - Team T-Rex disability-experience engineering Engineering topics

Comments

@aurora-a-k-a-lightning
Copy link
Contributor

aurora-a-k-a-lightning commented Apr 15, 2024

Issue Description

Make sure vets-api can call LH's /generatePDF endpoint and receive a 526 PDF filled out as expected.
https://dev-developer.va.gov/explore/api/benefits-claims/docs?version=current


Tasks

  • create LH benefits-claims service#generatePdf method
  • save pdf in temporary storage for later use
  • update Form526 to LH Transformation Service if necessary

Acceptance Criteria

  • vets-api can generate a 526 PDF with LH's /generatePdf endpoint
  • generated Pdf is in on local file system - this will be done in a later story as Team 1 has shifted implementation strategy

How to configure this issue

  • Attached to a Milestone (when will this be completed?)
  • Attached to an Epic (what body of work is this a part of?)
  • Labeled with Team (product support, analytics-insights, operations, service-design, Console-Services, tools-fe)
  • Labeled with Practice Area (backend, frontend, devops, design, research, product, ia, qa, analytics, contact center, research, accessibility, content)
  • Labeled with Type (bug, request, discovery, documentation, etc.)
@aurora-a-k-a-lightning aurora-a-k-a-lightning added backend disability-experience engineering Engineering topics needs-refinement Identifies tickets that need to be refined DBEX-TREX Disability Benefits Experience - Team T-Rex labels Apr 15, 2024
@RakshindaAslam RakshindaAslam removed the needs-refinement Identifies tickets that need to be refined label Apr 16, 2024
@sethdarragile6 sethdarragile6 self-assigned this Apr 17, 2024
@sethdarragile6
Copy link
Contributor

We have the following PR out which

  1. Allows us to overload the submission service to generate a PDF
  2. Strips out certain special characters (like \n and \r) which were causing an issue downstream in the PDF generation service (thread)
  3. Adds system/526-pdf.override API scope to BC calls, which is needed for PDF generation (thread)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend DBEX-TREX Disability Benefits Experience - Team T-Rex disability-experience engineering Engineering topics
Projects
None yet
Development

No branches or pull requests

3 participants