Add direct deposit email notification template #16357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fairs/vets-api into add-direct-deposit-notify-template
…fairs/vets-api into add-direct-deposit-notify-template
…for the direct deposit type.
va-vfs-bot
temporarily deployed
to
add-direct-deposit-notify-template/main/main
…fairs/vets-api into add-direct-deposit-notify-template
adamwhitlock1
approved these changes
Apr 17, 2024
rmtolmach
approved these changes
Apr 17, 2024
rmtolmach
added a commit
that referenced
this pull request
Apr 17, 2024
* Refactor uploads spec, simple forms (#16380) * Refactor uploads spec, simple forms * rubocop * BTSSS-77372 Add mocked responses for BTSSS (#16231) * Revert to original token URL in service * Add authorized ping mock, too * Handle Bearer Token parsing failures gracefully * Clean up services config * Revert some accidental deletions * Final bit of cleanup * Switch to correct file path * Move authorize method to a before_action * Update mockdata paths * Fix some linting errors * Add direct deposit email notification template (#16357) * Add template_type method to VANotifyEmailJob * Update direct deposit email job to accept a default parameter of nil for the direct deposit type. * Add method to request a token from STS (#16372) * Add method to request a token from STS * fix rubocop * Fix tests * Remove debugging line * change parameter to reflect actual value * Merge conflict fix * remove diff file from merge conflict * [80904] Creating a terms of use application check that occurs during secondary authentications with custom (#16371) --------- Co-authored-by: Eric Tillberg <[email protected]> Co-authored-by: Dan Hinze <[email protected]> Co-authored-by: Tom Harrison <[email protected]> Co-authored-by: Kevin Duensing <[email protected]> Co-authored-by: Trevor Bosaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, when a user updates their direct deposit info, they receive an email notification stating their direct deposit details was updated. The email notification should only state that their direct deposit info was updated without specifying the benefit type.
The email is sent using VA Notify's API, so a new email template called "Direct Deposit Update Confirmation" has been created.
This ticket
va_notifysettings.Related PRs
Related issue(s)
department-of-veterans-affairs/va.gov-team#80210
Testing done
Added/updated specs in: