Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate mobile usage of Direct Deposit, specifically C&P + EDU Forms #8332

Closed
Tonksthebear opened this issue Apr 8, 2024 · 3 comments
Closed
Assignees
Labels

Comments

@Tonksthebear
Copy link
Contributor

I received the following message:

"We are finishing up the work for combining the two separate direct deposit forms (C&P and EDU) into a single form. This means users will only manage one direct deposit account that applies to either C&P, EDU, or both.
When the form is displayed, the Profile section will inform users about which benefit type the direct deposit information is related to (C&P, EDU, or both). To determine the benefit type, Lighthouse has added an additional flag to the control information - isEduClaimAvailable.
So the basic logic is this...
if isCorpAvailable == true # then DD info is for C&P benefits.
if isEduClaimAvailable == true # then DD info is for EDU benefits.
if isCorpAvailable && isEduClaimAvailable # then DD info is for C&P and EDU benefits.
I know you mentioned that mobile doesn't have the EDU direct deposit feature, but the current mobile C&P form may need an update to better inform users about which benefit types the account is associated with.
If all goes well, we plan to deploy these change to production by Apr 20.
Let me know if you want to discuss this further."

We need to investigate if/how this affects us

@jperk51
Copy link
Contributor

jperk51 commented Apr 9, 2024

might be related to the migration I linked in the dependencies

@StacyB2023
Copy link
Contributor

StacyB2023 commented Apr 16, 2024

Adding this thread here for reference: https://dsva.slack.com/archives/C06JV0KHZNF/p1713211656845489 . This ticket covers the investigation.

Decision from POs was not to update Copy in the mobile app to include educational benefits because this would need an off cycle release to meet the April 20th deadline. For now we would like to investigate what our BE tells us regarding benefits etc. I was noted that mobile does not display education benefits at this point in time (will after april 29th).

cc: @aherzberg @jperk51 @Tonksthebear

@aherzberg
Copy link
Contributor

Just talked with Tom Harrison from the profile team and they are going to be displaying direct deposit information generically, without displaying if it's EDU or C&P. I suggest we do the same. Luckily our FE is already generic and does not mention C&P so the changes required from BE will be minimal. The only change that will be required if we do not need to pull in these new flags (since we wouldn't need to label if it's EDU or C&P on the FE) will be to update the confirmation email to be generic instead of referencing C&P as it does now. Tom has a PR out to do this department-of-veterans-affairs/vets-api#16357. once that is merged, I'll change our controller to use the new email template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants