Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create accredited_individuals table #16295

Merged
merged 5 commits into from
Apr 16, 2024
Merged

Create accredited_individuals table #16295

merged 5 commits into from
Apr 16, 2024

Conversation

holdenhinkle
Copy link
Contributor

@holdenhinkle holdenhinkle commented Apr 11, 2024 •
edited
Loading

References department-of-veterans-affairs/va.gov-team#80656

Summary

This PR creates the following new table:

  • accredited_individuals

Related issue(s)

Testing done

  • NA

Screenshots

Note: Optional

What areas of the site does it impact?

The database
The schema.rb file

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to hh-create-accredited_individuals_table/main/main April 11, 2024 16:05 Inactive
@holdenhinkle holdenhinkle marked this pull request as ready for review April 11, 2024 16:53
@holdenhinkle holdenhinkle requested review from a team as code owners April 11, 2024 16:53
@holdenhinkle holdenhinkle mentioned this pull request Apr 11, 2024
Merged
8 tasks
@jvcAdHoc jvcAdHoc mentioned this pull request Apr 11, 2024
Merged
8 tasks
@va-vfs-bot va-vfs-bot temporarily deployed to hh-create-accredited_individuals_table/main/main April 11, 2024 16:59 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to hh-create-accredited_individuals_table/main/main April 11, 2024 18:52 Inactive
jvcAdHoc
jvcAdHoc previously approved these changes Apr 12, 2024
View reviewed changes
@jvcAdHoc jvcAdHoc added the NOT_YET Don't merge this PR w/o the authors permission label Apr 12, 2024
@jvcAdHoc jvcAdHoc force-pushed the hh-create-accredited_individuals_table branch from 85cf0f5 to b219f0b Compare April 15, 2024 14:43
@va-vfs-bot va-vfs-bot temporarily deployed to hh-create-accredited_individuals_table/main/main April 15, 2024 15:01 Inactive
@jvcAdHoc jvcAdHoc force-pushed the hh-create-accredited_individuals_table branch from b219f0b to bc963fb Compare April 15, 2024 17:39
@jvcAdHoc jvcAdHoc removed the NOT_YET Don't merge this PR w/o the authors permission label Apr 15, 2024
@platform-support-slack-integration platform-support-slack-integration bot mentioned this pull request Apr 15, 2024
Closed
@jvcAdHoc jvcAdHoc merged commit 9f5164e into master Apr 16, 2024
20 checks passed
@jvcAdHoc jvcAdHoc deleted the hh-create-accredited_individuals_table branch April 16, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvcAdHoc jvcAdHoc jvcAdHoc approved these changes

@rmtolmach rmtolmach rmtolmach approved these changes

Assignees

@holdenhinkle holdenhinkle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@holdenhinkle @rmtolmach @jvcAdHoc @va-vfs-bot