Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create accredited_organizations table #16296

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

holdenhinkle
Copy link
Contributor

@holdenhinkle holdenhinkle commented Apr 11, 2024

References department-of-veterans-affairs/va.gov-team#80656

Summary

This PR creates the following new table:

  • accredited_organizations

Related issue(s)

Testing done

  • NA

Screenshots

Note: Optional

What areas of the site does it impact?

The database
The schema.rb file

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to hh-create-accredited_organizations_table/main/main April 11, 2024 16:18 Inactive
@holdenhinkle holdenhinkle marked this pull request as ready for review April 11, 2024 16:54
@holdenhinkle holdenhinkle requested review from a team as code owners April 11, 2024 16:54
db/schema.rb Outdated
@@ -53,6 +53,72 @@
t.index ["uuid"], name: "index_accounts_on_uuid", unique: true
end

create_table "accredited_individuals", id: :uuid, default: -> { "gen_random_uuid()" }, force: :cascade do |t|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This schema change shouldn't be caused by the migration. Likely from local development of both tables in parallel. This pr might cause a merge conflict.

@va-vfs-bot va-vfs-bot temporarily deployed to hh-create-accredited_organizations_table/main/main April 11, 2024 17:05 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to hh-create-accredited_organizations_table/main/main April 11, 2024 20:42 Inactive
jvcAdHoc
jvcAdHoc previously approved these changes Apr 12, 2024
@jvcAdHoc jvcAdHoc added the NOT_YET Don't merge this PR w/o the authors permission label Apr 12, 2024
@jvcAdHoc jvcAdHoc force-pushed the hh-create-accredited_organizations_table branch from 05cecf1 to 213001f Compare April 16, 2024 16:18
@jvcAdHoc jvcAdHoc added NOT_YET Don't merge this PR w/o the authors permission and removed NOT_YET Don't merge this PR w/o the authors permission labels Apr 16, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to hh-create-accredited_organizations_table/main/main April 16, 2024 16:23 Inactive
@jvcAdHoc jvcAdHoc merged commit 0b0ce7e into master Apr 16, 2024
20 checks passed
@jvcAdHoc jvcAdHoc deleted the hh-create-accredited_organizations_table branch April 16, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants