-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create accredited_organizations table #16296
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
hh-create-accredited_organizations_table/main/main
April 11, 2024 16:18
Inactive
jvcAdHoc
reviewed
Apr 11, 2024
8 tasks
jvcAdHoc
reviewed
Apr 11, 2024
db/schema.rb
Outdated
@@ -53,6 +53,72 @@ | |||
t.index ["uuid"], name: "index_accounts_on_uuid", unique: true | |||
end | |||
|
|||
create_table "accredited_individuals", id: :uuid, default: -> { "gen_random_uuid()" }, force: :cascade do |t| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This schema change shouldn't be caused by the migration. Likely from local development of both tables in parallel. This pr might cause a merge conflict.
va-vfs-bot
temporarily deployed
to
hh-create-accredited_organizations_table/main/main
April 11, 2024 17:05
Inactive
va-vfs-bot
temporarily deployed
to
hh-create-accredited_organizations_table/main/main
April 11, 2024 20:42
Inactive
jvcAdHoc
previously approved these changes
Apr 12, 2024
jvcAdHoc
force-pushed
the
hh-create-accredited_organizations_table
branch
from
April 16, 2024 16:18
05cecf1
to
213001f
Compare
jvcAdHoc
approved these changes
Apr 16, 2024
jvcAdHoc
added
NOT_YET
Don't merge this PR w/o the authors permission
and removed
NOT_YET
Don't merge this PR w/o the authors permission
labels
Apr 16, 2024
va-vfs-bot
temporarily deployed
to
hh-create-accredited_organizations_table/main/main
April 16, 2024 16:23
Inactive
jvcAdHoc
force-pushed
the
hh-create-accredited_organizations_table
branch
from
April 16, 2024 18:55
213001f
to
4525df2
Compare
rmtolmach
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References department-of-veterans-affairs/va.gov-team#80656
Summary
This PR creates the following new table:
Related issue(s)
Testing done
Screenshots
Note: Optional
What areas of the site does it impact?
The database
The schema.rb file
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?