Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create accredited_individuals_accredited_organizations table #16297

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

holdenhinkle
Copy link
Contributor

@holdenhinkle holdenhinkle commented Apr 11, 2024

References department-of-veterans-affairs/va.gov-team#80656

The following PRs must be merged first:

Summary

This PR creates the following new table:

  • accredited_individuals_accredited_organizations

Related issue(s)

Testing done

  • NA

Screenshots

Note: Optional

What areas of the site does it impact?

The database
The schema.rb file

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@jvcAdHoc jvcAdHoc merged commit 92bc70a into master Apr 18, 2024
20 checks passed
@jvcAdHoc jvcAdHoc deleted the hh-create-individuals_organizations-table branch April 18, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants