Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Migration of InProgressForm Status Column #16094

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

tfink419
Copy link
Contributor

@tfink419 tfink419 commented Mar 26, 2024

Summary

Related issue(s)

Testing done

  • Ran db migration and rake task locally, verified code in final PR works
  • [ ] New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

What areas of the site does it impact?

Will be used to determine whether to display form on site

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@tfink419 tfink419 changed the title Dbex inprogress form state migration 77171 Data Migration of InProgressForm Status Mar 26, 2024
@tfink419 tfink419 changed the title Data Migration of InProgressForm Status Data Migration of InProgressForm Status Column Mar 26, 2024
@tfink419 tfink419 force-pushed the dbex-inprogress-form-state-migration-77171 branch from 328bccf to e329262 Compare March 26, 2024 21:08
@tfink419 tfink419 changed the base branch from master to dbex-add-status-to-inprogress-forms-77171 March 26, 2024 21:17
@tfink419 tfink419 added the dependents-benefits Label used for Pull Requests that impact Add/Remove Dependents claims (686c/674) label Mar 26, 2024
Base automatically changed from dbex-add-status-to-inprogress-forms-77171 to master March 28, 2024 15:24
@va-vfs-bot va-vfs-bot temporarily deployed to dbex-inprogress-form-state-migration-77171/main/main March 28, 2024 15:34 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dbex-inprogress-form-state-migration-77171/main/main April 1, 2024 15:06 Inactive
@tfink419 tfink419 merged commit 13a7843 into master Apr 10, 2024
20 checks passed
@tfink419 tfink419 deleted the dbex-inprogress-form-state-migration-77171 branch April 10, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependents-benefits Label used for Pull Requests that impact Add/Remove Dependents claims (686c/674)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants