Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Status Column to InProgressForm #15873

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

tfink419
Copy link
Contributor

@tfink419 tfink419 commented Mar 11, 2024

Summary

Related issue(s)

Testing done

  • Ran db migration and rake task locally, verified code in final PR works
  • [ ] New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

What areas of the site does it impact?

Will be used to determine whether to display form on site

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vfs-bot va-vfs-bot temporarily deployed to dbex-add-status-to-inprogress-forms-77171/main/main March 11, 2024 19:51 Inactive
tblackwe
tblackwe previously approved these changes Mar 11, 2024
@tfink419 tfink419 added the dependents-benefits Label used for Pull Requests that impact Add/Remove Dependents claims (686c/674) label Mar 13, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to dbex-add-status-to-inprogress-forms-77171/main/main March 13, 2024 21:51 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dbex-add-status-to-inprogress-forms-77171/main/main March 13, 2024 22:07 Inactive
tblackwe
tblackwe previously approved these changes Mar 26, 2024
@tfink419 tfink419 marked this pull request as ready for review March 27, 2024 16:28
@tfink419 tfink419 requested review from a team as code owners March 27, 2024 16:28
@tfink419 tfink419 merged commit b9e4492 into master Mar 28, 2024
25 of 26 checks passed
@tfink419 tfink419 deleted the dbex-add-status-to-inprogress-forms-77171 branch March 28, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependents-benefits Label used for Pull Requests that impact Add/Remove Dependents claims (686c/674)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants