Use New Status Field to Maintain InProgressForm Data for Dependents Application

[tfink419]

Summary

• In case of failure, InProgressForm is no longer deleted and now a status field is updated and the forms are not shown if the field is set
• Code is split into 3 PR's
  • Add Status Column to InProgressForm #15873
  • Data Migration of InProgressForm Status Column #16094
  • Use New Status Field to Maintain InProgressForm Data for Dependents Application #15875

Related issue(s)

department-of-veterans-affairs/va.gov-team/issues/77171

Testing done

• New code is covered by unit tests
• In progress form would be deleted immediately, now it is saved until submission succeeds or fails the final time
• Submit a dependents change application and check if the form still appears immediately after submission, and that it will reappear after the status is changed back (normally after failures)

Screenshots

Pending Submission:

Processing Submission:

What areas of the site does it impact?

Dependents application submission

Acceptance criteria

• ~ I fixed|updated|added unit tests and integration tests for each feature (if applicable). ~
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[github-actions]

1 Error

🚫

Modified files in db/ should be the only files checked into this PR. File Summary DB File(s) db/migrate/20240313211432_add_status_to_inprogress_form.rb db/migrate/20240313211541_add_status_to_inprogress_form_default.rb db/schema.rb App File(s) app/controllers/v0/dependents_applications_controller.rb app/controllers/v0/in_progress_forms_controller.rb app/models/in_progress_form.rb app/services/bgs/dependent_service.rb app/services/users/profile.rb app/sidekiq/bgs/submit_form674_job.rb app/sidekiq/bgs/submit_form686c_job.rb Database migrations do not run automatically with vets-api deployments. Application code must always be backwards compatible with the DB, both before and after migrations have been run. For more info: vets-api Database Migrations vets-api Deployment Process

Generated by 🚫 Danger

[va-vsp-bot]

Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file:

[va-vsp-bot]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: