VACMS-15911: Updates config and code for spotlight content #16145

omahane · 2023-11-15T22:21:55Z

Description

Relates to #15911

Testing done

Manually

Screenshots

VBA Facility

Vet Center Dashboard

Vet Center

QA steps

VBA Facility

As [email protected], edit a VBA facility
Confirm that the labeling of Spotlight items is clear and correct
Add a local spotlight
Add another local spotlight
Confirm that you cannot add a third spotlight
Save the node
Confirm that the spotlight information appears in the Spotlight group

Vet Center dashboard

Go to the Vet Center dashboard
Confirm the change from "Featured content" to "Spotlight content"
Click Go to Spotlight content
Confirm that this takes you to the spotlight content of the Vet Center

Vet Center node

Confirm the change from "Featured content" to "Spotlight content" on the Vet Center node

Definition of Done

Documentation has been updated, if applicable.
Tests have been added if necessary.
Automated tests have passed.
Code Quality Tests have passed.
Acceptance Criteria in related issue are met.
Manual Code Review Approved.
If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

omahane · 2023-11-15T22:52:42Z

@davidmpickett I am looking at a VBA Facility and I'm not sure if it reads quite right, lots of "Spotlight content"s.

The same is true (perhaps to a lesser extent) for Vet Center.

davidmpickett · 2023-11-16T16:20:01Z

config/sync/field.storage.node.field_local_spotlight.yml

+module: entity_reference_revisions
+locked: false
+cardinality: 2
+translatable: true


I'm pretty sure Translatable should be false

I don't see anything in the UI that enables this to be turned off. I could set it to false here. Is that the recommendation, @swirtSJW ?

This might not be an issue. Language support is disabled for this field type and you have set translation to false on the field settings. I didn't realize this was field.storage when I left the comment. Sorry

This should be fine. The entity field that is the entity reference is translatable, even though the paragraph itself is not (would just point to a different paragraph).

davidmpickett · 2023-11-16T16:21:13Z

config/sync/field.field.paragraph.featured_content.field_section_header.yml

@@ -9,7 +9,7 @@ id: paragraph.featured_content.field_section_header
 field_name: field_section_header
 entity_type: paragraph
 bundle: featured_content
-label: 'Section Header'
+label: Title
 description: ''
 required: true
 translatable: false


By contrast, I think this field should be translatable. Possible that I'm totally misunderstanding translation though

A paragraph can generally not be translatable. Meaning if the node was translated, it would use its own paragraph, not a translation of the original paragraph.

davidmpickett · 2023-11-16T16:22:39Z

config/sync/field.field.node.vet_center.field_vet_center_feature_content.yml

@@ -12,7 +12,7 @@ id: node.vet_center.field_vet_center_feature_content
 field_name: field_vet_center_feature_content
 entity_type: node
 bundle: vet_center
-label: 'Featured content'
+label: 'Spotlight content'


Consider 'Local spotlight(s)' to avoid duplication of 'Spotlight content' phrase

config/sync/field.field.node.vet_center.field_vet_center_feature_content.yml

config/sync/field.field.node.vba_facility.field_local_spotlight.yml

davidmpickett · 2023-11-16T16:30:31Z

config/sync/core.entity_form_display.node.vet_center.default.yml

-      title: 'featured content block'
-      title_plural: 'featured content blocks'
+      title: 'spotlight contents'
+      title_plural: spotlights


I am even more convinced now that these fields don't do what they say they do.

Sorry I am not sure I follow what you are saying @davidmpickett

Just pointing out that the first two fields in Paragraphs (stable) field widget don't actually do what they say they do. The actual source of the button text seems to be the Paragraph label.

It's not a big deal (or in scope for this ticket) it's just confusing

config/sync/core.entity_form_display.node.vet_center.default.yml

davidmpickett · 2023-11-16T16:59:34Z

Two other files that might warrant small edits:

field.field.node.vba_facility.field_cc_national_spotlight_1.yml

label: 'National spotlight 1'

field.field.node.vet_center.field_cc_vet_center_featured_con.yml

🍇 label: 'National~~ly featured Vet Center content~~ spotlight'

davidmpickett

Thanks for making all those updates. Looks good to me

swirtSJW · 2023-11-19T21:20:57Z

I was not able to login with this user.

I'll look into it.

swirtSJW · 2023-11-20T00:36:42Z

I am fixing the conflicts now.

swirtSJW

This tests out great and is ready for merge.

However, this makes changes to the Vet Center product that were not really scoped in the original ticket and may need some change management with editors and perhaps KBs that were not part of the issue either. So I am not sure if this can be merged.

@davidmpickett and @xiongjaneg please advise.

swirtSJW · 2023-11-20T01:57:09Z

davidmpickett · 2023-11-20T02:06:33Z

This tests out great and is ready for merge.

However, this makes changes to the Vet Center product that were not really scoped in the original ticket and may need some change management with editors and perhaps KBs that were not part of the issue either. So I am not sure if this can be merged.

@davidmpickett and @xiongjaneg please advise.

Linking to ongoing slack thread about change management

laflannery · 2023-11-20T14:07:39Z

Approved

swirtSJW · 2023-11-20T18:34:11Z

Discussed the need for Change management in today's scrum and Jane and Michelle both gave the thumbs up to go ahead and merge.

* VACMS-15911: Updates config and code for spotlight content * VACMS-15911: Updates the labeling of spotlight in VBA form * VACMS-15911: Updates VBA node:view * VACMS-15911: Update config after PR * VACMS-15911 Move local spotlight out of external content. --------- Co-authored-by: Steve Wirt <[email protected]> Co-authored-by: Steve Wirt <[email protected]>

omahane requested review from a team as code owners November 15, 2023 22:21

va-cms-bot temporarily deployed to Tugboat November 15, 2023 22:21 Destroyed

davidmpickett mentioned this pull request Nov 16, 2023

Add Featured Content ("in the spotlight") to VBA Facility Content Type #15911

Closed

8 tasks

va-cms-bot temporarily deployed to Tugboat November 16, 2023 14:02 Destroyed

va-cms-bot temporarily deployed to Tugboat November 16, 2023 15:35 Destroyed

omahane requested a review from davidmpickett November 16, 2023 15:56

github-actions bot added the Facilities Facilities products (VAMC, Vet Center, etc) label Nov 16, 2023

davidmpickett reviewed Nov 16, 2023

View reviewed changes

config/sync/field.field.node.vet_center.field_vet_center_feature_content.yml Outdated Show resolved Hide resolved

davidmpickett reviewed Nov 16, 2023

View reviewed changes

config/sync/field.field.node.vba_facility.field_local_spotlight.yml Show resolved Hide resolved

davidmpickett reviewed Nov 16, 2023

View reviewed changes

config/sync/core.entity_form_display.node.vet_center.default.yml Show resolved Hide resolved

davidmpickett previously approved these changes Nov 16, 2023

View reviewed changes

omahane requested a review from swirtSJW November 16, 2023 19:34

va-cms-bot temporarily deployed to Tugboat November 16, 2023 21:33 Destroyed

omahane added 4 commits November 19, 2023 20:06

VACMS-15911: Updates config and code for spotlight content

5a81875

VACMS-15911: Updates the labeling of spotlight in VBA form

5a40a0c

VACMS-15911: Updates VBA node:view

47c8a28

VACMS-15911: Update config after PR

525c4a8

swirtSJW dismissed davidmpickett’s stale review via 525c4a8 November 20, 2023 01:08

swirtSJW force-pushed the VACMS-15911-add-featured-content-vba branch from 8315212 to 525c4a8 Compare November 20, 2023 01:08

va-cms-bot temporarily deployed to Tugboat November 20, 2023 01:08 Destroyed

VACMS-15911 Move local spotlight out of external content.

e0a5f39

swirtSJW previously approved these changes Nov 20, 2023

View reviewed changes

swirtSJW dismissed their stale review via e0a5f39 November 20, 2023 02:38

va-cms-bot temporarily deployed to Tugboat November 20, 2023 02:38 Destroyed

swirtSJW approved these changes Nov 20, 2023

View reviewed changes

Merge branch 'main' into VACMS-15911-add-featured-content-vba

c79b1cd

swirtSJW merged commit fe33e58 into main Nov 20, 2023
7 checks passed

va-cms-bot temporarily deployed to Tugboat November 20, 2023 18:34 Destroyed

swirtSJW deleted the VACMS-15911-add-featured-content-vba branch November 20, 2023 18:34

This was referenced Dec 15, 2023

is change_labels breaking paragraph field widget? #16448

Closed

Paragraph [Add more] button label not respecting field widget settings #16452

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VACMS-15911: Updates config and code for spotlight content #16145

VACMS-15911: Updates config and code for spotlight content #16145

omahane commented Nov 15, 2023 •

edited by swirtSJW

Loading

omahane commented Nov 15, 2023 •

edited

Loading

davidmpickett Nov 16, 2023

omahane Nov 16, 2023

davidmpickett Nov 16, 2023

swirtSJW Nov 19, 2023

davidmpickett Nov 16, 2023

swirtSJW Nov 19, 2023

davidmpickett Nov 16, 2023

davidmpickett Nov 16, 2023

davidmpickett Nov 16, 2023

swirtSJW Nov 19, 2023

davidmpickett Nov 20, 2023

davidmpickett commented Nov 16, 2023 •

edited

Loading

davidmpickett left a comment

swirtSJW commented Nov 19, 2023

swirtSJW commented Nov 20, 2023 •

edited

Loading

swirtSJW left a comment

swirtSJW commented Nov 20, 2023

davidmpickett commented Nov 20, 2023

laflannery commented Nov 20, 2023

swirtSJW commented Nov 20, 2023

VACMS-15911: Updates config and code for spotlight content #16145

VACMS-15911: Updates config and code for spotlight content #16145

Conversation

omahane commented Nov 15, 2023 • edited by swirtSJW Loading

Description

Testing done

Screenshots

VBA Facility

Vet Center Dashboard

Vet Center

QA steps

VBA Facility

Vet Center dashboard

Vet Center node

Definition of Done

Select Team for PR review

omahane commented Nov 15, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davidmpickett commented Nov 16, 2023 • edited Loading

davidmpickett left a comment

Choose a reason for hiding this comment

swirtSJW commented Nov 19, 2023

swirtSJW commented Nov 20, 2023 • edited Loading

swirtSJW left a comment

Choose a reason for hiding this comment

swirtSJW commented Nov 20, 2023

davidmpickett commented Nov 20, 2023

laflannery commented Nov 20, 2023

swirtSJW commented Nov 20, 2023

omahane commented Nov 15, 2023 •

edited by swirtSJW

Loading

omahane commented Nov 15, 2023 •

edited

Loading

davidmpickett commented Nov 16, 2023 •

edited

Loading

swirtSJW commented Nov 20, 2023 •

edited

Loading