Add Featured Content ("in the spotlight") to VBA Facility Content Type

[davidmpickett]

User story

As a VBA editor, I want to be able to feature a timely event or other information to get Veterans' attention.

Background

Summary of business feedback/decisions from Office of Strategic engagement:
Design should include:

• 1 centralized/national spotlight with 2 local/editor level spotlights

Use the Featured Content paragraph from Vet Center

Also see Laura's comment in 13799

• Featured content:
  -Change label to Spotlight content - this will help with consistency and lessen confusion by aligning CMS and FE naming conventions
• Section Header
  -Change label to Title - section is a term used very specifically for something else within the CMS so should be avoided whenever possible to refer to other things.
  -Keep field as required
  -Keep field as a text input
  -Keep character limit at 80

Acceptance criteria

• @davidmpickett drafts a clear spec for fields that need to change and reviews with @omahane before @omahane starts implementation
• @davidmpickett assesses impact of changes on Vet Centers, and brings that to Product for approval / change management. If Laura's requested updates to fields used on Vet Centers becomes a blocker, that work should split off from adding the fields AS IS to VBA
• VBA Featured Content is implemented in the same way as Vet Center Featured Content (with the following changes)
  • Featured content label is changed to Spotlight content
  • Section Header label is changed to title
• There is one centralized content field and one local content field with cardinality of two
• @davidmpickett QAs @omahane's PR
• @laflannery a11y review

[davidmpickett]

This was listed as a comment on 14699, but doesn't look like that ever got addressed or turned into a ticket

[davidmpickett]

See also Laura's comments on implementation #13799 (comment)

[xiongjaneg]

Michelle's comment in Slack about making sure 3 spotlights show

[davidmpickett]

Re updated description. To avoid confusion, I would narrow this to only the spotlight piece

• Gov Delivery
• national social media only (no local)
• 1 centralized/national spotlight with 2 local/editor level spotlights
• AVA and VERA

Those other three items are handled by entirely different parts of the system.

[davidmpickett]

Content spec (VBA specific)

VBA Facility Content Type

• Remove field_cc_national_spotlight_2
• Remove field_cc_national_spotlight_3
• Add field_local_spotlight
  • Field type: Entity reference revision -> "Featured content" paragraph type
  • Label: Spotlight content
  • Cardinality: 2
  • Translatable: No
• Add fieldset "Spotlight content" to Form Display
  • Description: Highlight up to two benefit office activities, such as events or programs.
  • Fields to include in fieldset
    • National spotlight tooltip
    • National spotlight 1
    • field_local_spotlight

Centralized Content | VBA -- benefit office content

• Remove Featured content "Do you have the latest VA form?"
• Remove Featured content "Six essential facts"

Content spec (Vet center and beyond)

Featured Content - paragraph type

• Change label -> 'Spotlight content'
• Machine name will stay: featured_content
• field_section_header
  • Change label -> 'Title'

Vet Center

• field_vet_center_feature_content
  • Change label -> 'Spotlight content'
  • Do these Paragraphs (stable) field widget settings actually do what they say they do? If so, update them.
    • Paragraph Title -> spotlight content
    • Plural Paragraph Title -> spotlights
• "Featured content" fieldset
  • Field group label -> Spotlight content
• "National featured content" fieldset
  • Field group label -> National spotlight content
  • Tooltip Description -> Why can’t I edit this? This national feature spotlight managed by VHA will display alongside locally-relevant content.

[davidmpickett]

@omahane let me know if this spec makes sense or if you need any clarifications

[mmiddaugh]

if we're moving to "Spotlight", the Vet Center dashboard will also need to be updated.

[omahane]

@swirtSJW @davidmpickett Do you have time to look at this, as I've already run into some unexpected trouble.

I'm thinking that this means that other content types that are using the paragraph already have more than the number I'm trying to limit it to, which means that the limit is not set per content type but on the paragraph itself, which, as a shared field means that we are trying to butt in on someone else's content.

So, @dave Pickett I think we might be already running into a change management issue with #1. We could always keep it unlimited and say that only the first two will ever show, but that's clunky. Or we make a new Paragraph. I'll bring this discussion to the issue.

[omahane]

@swirtSJW @davidmpickett Do you have time to look at this, as I've already run into some unexpected trouble.

After a quick Zoom, Dave noticed that I had reused the field_featured_content rather than made a new field_local_spotlight.

Solved.

[davidmpickett]

Fun and not-at-all-confusing fact:
The "Featured content" field on VAMC Detail Pages and Benefits Detail Page uses the Rich Text and Page-Specific Q&A paragraph types rather than the Featured Content (soon to be Spotlight Content) paragraph type.

[laflannery]

I want to note that the screenshot above is Featured Content, not Spotlight content for VAMCs. It is separate from what is being worked on in this ticket. The spotlight content is on the VAMC System page and is quite different from the pattern being worked on here and is documented in this issue to be handled at future time

[davidmpickett]

Responding to @omahane comment on the PR back on the main ticket for visibility.

How about:

• "Spotlight content" - for fieldset that groups everything (could also be "In the spotlight")
• "National spotlight" - for the cc fetch fields
• "Local spotlight(s)" - for the paragraph type heading
• "spotlight" - for the add another button (could also be "spotlight content")
• Let's move the help text about "add up two office activities" down closer to where the user would actually perform that action

[davidmpickett]

I want to note that the screenshot above is Featured Content, not Spotlight content for VAMCs. It is separate from what is being worked on in this ticket. The spotlight content is on the VAMC System page and is quite different from the pattern being worked on here and is documented in this issue to be handled at future time

@laflannery Sorry for any confusion. I was documenting it because this is the very thing that tripped up @omahane earlier today. He was accidentally reusing the field_featured_content, despite Featured Content being a totally separate thing from Spotlight Content.

[davidmpickett]

Made these charts for my own sanity

Stuff that's actually part of this ticket

Thing	Current Label	New Label	Machine name
Paragraph type that powers "In the spotlight" on VBA and Vet Center	Featured Content	Spotlight Content	featured_content
Entity Reference Field that powers the above paragraph type for Vet Centers	Featured content	Local spotlight(s)	field_vet_center_feature_content
Entity Reference Field that powers the above paragraph type for VBA	Spotlight content	Local spotlight(s)	field_local_spotlight
Label on the button for adding another instance of paragraph type	Add Spotlight content	Add Spotlight ?	I am unclear on what actually determines this label

Not part of this ticket, but has confusingly similar names

Thing	Label	Machine name
Paragraph type that powers "In the spotlight" on VAMC	List of link teasers	list_of_link_teasers
Entity Reference Field that powers Featured Content for VAMC and Benefit Detail Pages	Featured content	field_featured_content
Paragraph types that power Featured Content for VAMC and Benefit Detail Pages	Rich text & Page-Specific Q&A	wysiwyg & q_a

[swirtSJW]

This location seems misleading.

[swirtSJW]

I fixed the location.

[swirtSJW]

This has been merged #16145
Nice work @omahane

[davidmpickett]

Uploading video clip for async demo:
https://github.com/department-of-veterans-affairs/va.gov-cms/assets/51967950/2d33c0e1-827c-47e0-adf0-4fe7ca3e76ed