Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paragraph [Add more] button label not respecting field widget settings #16452

Open
2 of 10 tasks
davidmpickett opened this issue Dec 15, 2023 · 3 comments
Open
2 of 10 tasks
Labels
CMS frontend CMS team practice area CMS Team CMS Product team that manages both editor exp and devops Defect Something isn't working (issue type) Drupal engineering CMS team practice area Needs refining Issue status UX debt Known issues with the user experience UX writing CMS team practice area

Comments

@davidmpickett
Copy link
Contributor

davidmpickett commented Dec 15, 2023

Describe the defect

AS A UX writer working on the Drupal CMS editorial interface
I NEED to specify the text that appears on buttons
SO THAT I can make the interface intuitive for CMS editors

However, for the case of Paragraph widgets, the label/title of [Add more] button is not respecting the text I enter into the Widget settings. I first noticed this on the Spotlight content paragraph type on Vet Centers. But I have also tested it on Service Location paragraph for VAMC Facility Service and VBA Facility Service. Not working.

I have a theory that there is a collision happening between the Paragraphs module (stable) Field Widget (code) and the Change Labels module (code) but don't have the Drupal chops to test if that's true, or if there's an entirely other part of our codebase that's ignoring overriding both of these things

This might be related to this upstream issue in the Paragraphs Module

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

AC / Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

284112817-c08e39b2-6cbd-43d0-ab33-1641e91d658b

Additional context

Add any other context about the problem here. Reach out to the Product Managers to determine if it should be escalated as critical (prevents users from accomplishing their work with no known workaround and needs to be addressed within 2 business days).

Desktop (please complete the following information if relevant, or delete)

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Labels

(You can delete this section once it's complete)

  • Issue type (red) (defaults to "Defect")
  • CMS subsystem (green)
  • CMS practice area (blue)
  • CMS workstream (orange) (not needed for bug tickets)
  • CMS-supported product (black)

Team

Please check the team(s) that will do this work.

  • CMS Team
  • Public Websites
  • Facilities
  • User support
  • Accelerated Publishing
@davidmpickett davidmpickett added CMS frontend CMS team practice area Defect Something isn't working (issue type) Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status UX writing CMS team practice area labels Dec 15, 2023
@davidmpickett davidmpickett changed the title Paragraph [Add more] button label not respecting widget settings Paragraph [Add more] button label not respecting field widget settings Dec 15, 2023
@xiongjaneg xiongjaneg added CMS Team CMS Product team that manages both editor exp and devops Needs Analysis Needs to reviewed by Product or Delivery before moving to backlog labels Dec 15, 2023
@xiongjaneg
Copy link
Contributor

xiongjaneg commented Dec 15, 2023

@maortiz-27-80 Dave found this defect and it appears to affect more than Facilities products. Dave also noted a potential related upstream Drupal issue and noted it in the ticket description. Noting it is preventing us from implementing some UX recommendations on CMS interfaces.

Thanks for your consideration!

@xiongjaneg xiongjaneg removed the Facilities Facilities products (VAMC, Vet Center, etc) label Dec 15, 2023
@maortiz-27-80
Copy link

Thanks for flagging, @xiongjaneg ! The team will review/refine and let you know if we have any questions. cc: @BerniXiongA6

@BerniXiongA6 BerniXiongA6 removed the Needs Analysis Needs to reviewed by Product or Delivery before moving to backlog label Jan 2, 2024
@BerniXiongA6
Copy link

Hey @edmund-dunn would you be able to pre-refine this ticket ahead of or by Sprint Planning 101? Let @maortiz-27-80 and/or me know if you wanted to sync up or if you could do this async.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS frontend CMS team practice area CMS Team CMS Product team that manages both editor exp and devops Defect Something isn't working (issue type) Drupal engineering CMS team practice area Needs refining Issue status UX debt Known issues with the user experience UX writing CMS team practice area
Projects
None yet
Development

No branches or pull requests

4 participants