VACMS-10089: Checkbox to add event to National Outreach Calendar #15552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alue in listing_field - Disable the checkbox if it needs to be.
- Adds the calendar to the event if the user is a hub only user.
… national outreach calendar' field.
… hub only user. - Restore the _none option.
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan) from 1.10.36 to 1.10.37. - [Release notes](https://github.com/phpstan/phpstan/releases) - [Changelog](https://github.com/phpstan/phpstan/blob/1.11.x/CHANGELOG.md) - [Commits](phpstan/phpstan@1.10.36...1.10.37) --- updated-dependencies: - dependency-name: phpstan/phpstan dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
docroot/modules/custom/va_gov_events/src/EventSubscriber/EntityEventSubscriber.php
Outdated
Show resolved
Hide resolved
docroot/modules/custom/va_gov_events/src/EventSubscriber/EntityEventSubscriber.php
Outdated
Show resolved
Hide resolved
chri5tia
force-pushed
the
VACMS-10089-nat-outreach-cal
branch
from
a732146 to
812b8c8
Compare
This reverts commit 2f81169.
chri5tia
commented
Oct 5, 2023
docroot/themes/custom/vagovclaro/assets/scss/components/_fields.scss
Outdated
Show resolved
Hide resolved
12 tasks
chri5tia
commented
Oct 6, 2023
There was a problem hiding this comment.
Removed because this test has become outdated and fails as the event form and it's tests have evolved. Fixing it would be redundant due to this test also running in other places, such as the CLP and Event features.
dsasser
reviewed
Oct 9, 2023
| @@ -0,0 +1,14 @@ | |||
| import { When } from "@badeball/cypress-cucumber-preprocessor"; | |||
|
|
|||
| When("I set the {string} feature toggle to {string}", (featureToggleMachineName, value) => { | |||
There was a problem hiding this comment.
Do you think it would benefit future us if we added a comment about changing this to a drush command, to avoid having to login as a specific user prior to doing the test?
There was a problem hiding this comment.
Good idea. I'll put this in the status update in my notes for future work.
dsasser
approved these changes
Oct 9, 2023
19 tasks
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to #10089
Testing done
Functional in CMS, cypress
Screenshots
QA steps
As a user with content_admin role:
As a user with the roles office_content_creator, content_publisher
Definition of Done
Select Team for PR review
CMS TeamPublic websitesFacilitiesUser supportAccelerated PublishingIs this PR blocked by another PR?
DO NOT MERGEDoes this PR need review from a Product Owner
Needs PO reviewCMS user-facing announcement
Is an announcement needed to let editors know of this change?