Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-10089: Putting cypress event form conditional test back in #15626

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

chri5tia
Copy link
Contributor

@chri5tia chri5tia commented Oct 10, 2023

Description

Relates to #15552
We inadvertently removed some tests that should have stayed.

Testing done

Local cypress test

Screenshots

n/a

QA steps

n/a

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@chri5tia chri5tia force-pushed the VACMS-10089-Put-Conditional-Tests-Back branch from 7f69d28 to 00c223d Compare October 10, 2023 16:40
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 10, 2023 16:40 Destroyed
@chri5tia chri5tia marked this pull request as ready for review October 10, 2023 17:17
@chri5tia chri5tia enabled auto-merge (squash) October 10, 2023 17:18
@chri5tia chri5tia disabled auto-merge October 10, 2023 20:01
@chri5tia chri5tia merged commit 4b4ff12 into main Oct 10, 2023
@chri5tia chri5tia deleted the VACMS-10089-Put-Conditional-Tests-Back branch October 10, 2023 20:02
dsasser added a commit that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants