Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "VACMS-10089: Checkbox to add event to National Outreach Calen… #15633

Merged
merged 4 commits into from
Oct 11, 2023

Conversation

chri5tia
Copy link
Contributor

@chri5tia chri5tia commented Oct 10, 2023

…dar (#15552)"

This reverts commit a36ad8c.

Description

Relates to #15552

Testing done

Compared changes to PRs that we are reverting to make sure everything was accounted for.

QA steps

n/a

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 10, 2023 22:07 Destroyed
@chri5tia chri5tia force-pushed the VACMS-10089-Revert-Outreach-Cal-Changes branch from a8f9f2e to 33b7ff3 Compare October 10, 2023 22:30
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 10, 2023 22:30 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 10, 2023 22:41 Destroyed
dsasser
dsasser previously approved these changes Oct 10, 2023
Copy link
Contributor

@dsasser dsasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good. Approving pending automated test results.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 10, 2023 23:28 Destroyed
@chri5tia chri5tia marked this pull request as ready for review October 11, 2023 00:00
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 11, 2023 01:25 Destroyed
Copy link
Contributor

@timcosgrove timcosgrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timcosgrove timcosgrove merged commit 6aa0f53 into main Oct 11, 2023
@timcosgrove timcosgrove deleted the VACMS-10089-Revert-Outreach-Cal-Changes branch October 11, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants