VACMS-15055: Accelerated Publishing Install and enable computed_breadcrumbs.

[schiavo]

Description

Include breadcrumb data to JSON API to support Accelerated Publishing Next js implememtation.
Relates to #14741 Spike: Breadcrumb modules for Drupal JSON:API

Testing done

Local testing comparing JSON API data with GraphQL data.

Screenshots

Before

After

Comparison with GraphQL results
GraphQL

JSON API

QA steps

1. Do this
   • Validate that breadcrumb data appears in JSON API e.g. /jsonapi/node/page
2. Then
   • Validate the UI is unaltered e.g. /node/add/page
3. Then validate Acceptance Criteria from issue

• Breadcrumb data is available in the JSON:API response for a node
• JSON:API breadcrumb data functionally matches GraphQL query data for equivalent queries/node types
• Installation of the module does not alter the editor experience in any way

Definition of Done

• Documentation has been updated, if applicable.
• Tests have been added if necessary.
• Automated tests have passed.
• Code Quality Tests have passed.
• Acceptance Criteria in related issue are met.
• Manual Code Review Approved.

Select Team for PR review

• CMS Team
• Public websites
• Facilities
• User support
• Accelerated Publishing

Is this PR blocked by another PR?

• DO NOT MERGE

[github-actions]

GitHub Workflows (.github/workflows/*.yml)

Have you...

• pinned all affected GitHub Actions at a specific commit by SHA?
• reviewed the source code of the action at the commit you are pinning?
• confirmed that no GitHub security measures are being bypassed?
• checked for any injection of user content into protected contexts?
• reviewed Security hardening for GitHub Actions?
• reviewed GitHub Workflows?

[tjheffner]

This appears to be working for me.

I am not sure what the CI failure is about... there are only 49 lines changed in composer.lock here 😉 And they are changes we want... so 🤷

Run thollander/actions-comment-pull-request@d61db783da9abefc3437960d0cce08552c7c004f
  with:
    comment_tag: check-composer-lock-changes
    message: The number of lines changed in composer.lock exceeds the acceptable threshold.
  
  - Lines changed: 50
  - Threshold: [2](https://github.com/department-of-veterans-affairs/va.gov-cms/actions/runs/6151340447/job/16691185057?pr=15193#step:5:2)00
  
  This is a warning only. Please review the changes and ensure that they are acceptable.
  
    GITHUB_TOKEN: ***
    mode: upsert
    create_if_not_exists: true
  env:
    LINES_CHANGED: [5](https://github.com/department-of-veterans-affairs/va.gov-cms/actions/runs/6151340447/job/16691185057?pr=15193#step:5:5)0
    THRESHOLD: 200
No comment has been found with asked pattern. Creating a new comment.
Error: Resource not accessible by integration

[ndouglas]

@tjheffner I believe it's a permissions issue:

Error: Resource not accessible by integration

GITHUB_TOKEN has read-only permissions on this PR because of the origin, so it can't write to the PR thread.

It doesn't matter, though. You can safely ignore it. I'll figure out a less annoying fallback.

[ndouglas]

This one is more interesting:

[ndouglas]

interesting. On main:

On this preview:

So it looks like this test is checking every single link, and then this PR adds a new link that doesn't conform 🤔

I'm not crazy about this test. I think it should restrict by a class or something. Because this is really an innocuous PR and it shouldn't break this test.

[ndouglas]

Opened an issue: #15196

[ndouglas]

@timcosgrove FYSA I think this PR is blocked by a bug in a Facilities test. Feel free to double-check me because it's late in the day for the ol' Nug Doug.

EDIT: Got bored, opened a PR.

[jilladams]

@laflannery should take a look at this from an a11y perspective.
Since it's CMS UX, @BlakeOrgan should also prob weigh in if he hasn't already.

[laflannery]

Would someone be able to more clearly tell me what I'm looking at? Such as:

• Is this CMS only, not VA.gov breadcrumbs?
• Am I just looking to make sure these match what is on Prod currently?
• Should I be testing any particular content types or are random nodes fine?
• Any known issues that I should be ignoring?
• Anything else?

Also the Tugboat failed

[tjheffner]

@laflannery @BlakeOrgan looking at CMS breadcrumbs only, and we'll have this PR environment working again for you ASAP.

The breadcrumbs will match prod CMS in most cases, but not all. Swirt's comment has a good breakdown of the differences between this PR, prod CMS, & the live site. Essentially some pages have gained a visible breadcrumb in the CMS that wasn't visible before. This new crumb matches what the breadcrumb visible on the live site in most cases.

Essentially looking from an a11y+ux perspective that including an extra breadcrumb for the current page is kosher.

Testing on random nodes is fine.

[laflannery]

I actually like the new, additional breadcrumb, this makes everything much more expected and consistent. I have no issues with this new display

[BlakeOrgan]

Approved. I like the addition of displaying the current page within the breadcrumbs.