Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vamc_lovell.feature test might be a tad hungry. #15196

Closed
1 task
ndouglas opened this issue Sep 11, 2023 · 0 comments · Fixed by #15209
Closed
1 task

vamc_lovell.feature test might be a tad hungry. #15196

ndouglas opened this issue Sep 11, 2023 · 0 comments · Fixed by #15209
Labels
Needs refining Issue status

Comments

@ndouglas
Copy link
Contributor

Description

See here. It looks like this test is checking for every <a> tag containing "Lovell Federal health care - TRICARE" and ensuring it has a href attribute of "lovell-federal-health-care-tricare". But Mr. Schiavone's PR introduces a new <a> tag that does not, which breaks the test.

This is probably just a bug in the test -- where someone wanted to look at a specific link and check its URL.

Reproduction (dev console)

  1. jQuery('a:contains("Lovell Federal health care - TRICARE")') -- should show like 57 links
  2. jQuery('a:contains("Lovell Federal health care - TRICARE"):not([href*="lovell-federal-health-care-tricare"])').show(); -- should show diddly
  3. jQuery('a:contains("Lovell Federal health care - TRICARE")') on Daniel's PR -- should show like 58 links
  4. jQuery('a:contains("Lovell Federal health care - TRICARE"):not([href*="lovell-federal-health-care-tricare"])').show(); -- should show a single benighted anchor link.

Acceptance Criteria

  • Tests check a specific link, rather than every link matching the criteria.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs refining Issue status
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant