VACMS-14793: Hide Link Description Field in Footers

[chri5tia]

Description

Related to #14793

Testing done

Local functional testing

Screenshots

Hides description field:

QA steps

As any testcontentadmin with the content_admin roll, go to admin/structure/menu/manage/footer-bottom-rail and click to edit any link.

• Ensure that the description field is not showing.

Go to admin/structure/menu/manage/va-gov-footer and click to edit any link.

• Ensure that the description field is not showing

Definition of Done

• Documentation has been updated, if applicable.
• Tests have been added if necessary.
• Automated tests have passed.
• Code Quality Tests have passed.
• Acceptance Criteria in related issue are met.
• Manual Code Review Approved.

Select Team for PR review

• CMS Team
• Public websites
• Facilities
• User support
• Accelerated Publishing

Is this PR blocked by another PR?

• DO NOT MERGE

Does this PR need review from a Product Owner

• Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

• Yes, and it's written in issue ____ and queued for publication.
  • Merge and ping the UX writer so they are ready to publish after deployment
• Yes, but it hasn't yet been written
  • Don't merge yet -- ping the UX writer to write and queue content
• No announcement is needed for this code change.
  • Merge & carry on unburdened by announcements

[dsasser]

Reminder: we don't want PRs to close issues automatically when they are merged. This gives us a chance to prod verify the solution before closing the issue:

[chri5tia]

@dsasser The PR is failing because the new trait MenuFormAlter lives in the new module va_gov_header_footer, which cannot be installed due to drush failing on this error, where the already-installed va_gov_home module depends on an expected trait that it can't find, throwing a drush error.

Here is what I was seeing in my browser locally:

Fatal error: Trait "Drupal\va_gov_header_footer\Traits\MenuFormAlter" not found in /var/www/html/docroot/modules/custom/va_gov_home/src/EventSubscriber/FormEventSubscriber.php on line 14

It makes sense that this wouldn't have been caught during development because the new module would have been installed already as part of the process.

I thought about simply adding a dependency in va_gov_home for va_gov_header_footer but this would still be an issue when merging to prod.

I propose that I move the new MenuFormAlter trait to the va_gov_home module instead, or move everything related to menus that is in va_gov_home and va_gov_header_footer to a module called va_gov_menus.

It would be nice if we could avoid having too many dependencies with custom modules toward each other in order to avoid circular dependencies. I know it can't be avoided and I see some like va_gov_home being dependent on va_gov_users but it would be nice to establish an hierarchy. This is a sidebar. But for this reason I think it'll be more elegant all the menu stuff to a menu module.
Thoughts?

Update: Turns out that there isn't anything left in va_gov_home after moving all the menu stuff.

[chri5tia]

Ticket created for follow up:
#15279

[dsasser]

Note for future us: this line should use the new trait added in va_gov_menus, but we can't roll out a new trait in a new module while also using it elsewhere in the codebase at the same time, as we get a php error:

PHP Fatal error:  Trait "Drupal\va_gov_menus\Traits\MenuFormAlterTrait" not found in /var/www/html/docroot/modules/custom/va_gov_header_footer/src/EventSubscriber/FormEventSubscriber.php on line 14

We will want to go back and leverage the trait here, as well as in va_gov_home (after moving va_gov_home's menu alter methods to the trait as well).

[dsasser]

Looks good!

As admin:

As non-admin: