VACMS:15279 utilize menu form alter in home module #15282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and footer menus. Co-authored-by: Daniel Sasser <[email protected]> Co-authored-by: Christia Troyer <[email protected]>
chri5tia
changed the title
chri5tia
changed the base branch from
main
to
VACMS-14793-Hide-Footer-Description-Field
swirtSJW
reviewed
Sep 17, 2023
| @@ -12,6 +13,8 @@ | |||
| */ | |||
| class FormEventSubscriber implements EventSubscriberInterface { | |||
|
|
|||
| use MenuFormAlter; | |||
There was a problem hiding this comment.
Suggestion: It is nice to follow the pattern of suffixing a trait with the word trait in it so it is clear what it is.
chri5tia
force-pushed
the
VACMS-14793-Hide-Footer-Description-Field
branch
3 times, most recently
from
909e431 to
b30241b
Compare
chri5tia
changed the base branch from
VACMS-14793-Hide-Footer-Description-Field
to
main
|
Closing and we can revisit later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up for work on hiding the link descriptions in certain menu fields, we crated a new menu form alter trait that can't be utilized by other modules until it is implemented. This PR addresses the ticket to break up that work and follow an order of operations. This is not ready to merge until PR #15069 is deployed to prod.
Relates to #15279
#14793
Engineering notes
This PR is in a state that just serves as a preview/reminder. It will need to be edited to show the base branch as "main".
Testing done
TBD
Screenshots
n/a
QA steps
TBD
Definition of Done
Select Team for PR review
CMS TeamPublic websitesFacilitiesUser supportAccelerated PublishingIs this PR blocked by another PR?
DO NOT MERGEDoes this PR need review from a Product Owner
Needs PO reviewCMS user-facing announcement
Is an announcement needed to let editors know of this change?