Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-15222: Unlock benefit taxonomy fields to content admins #15273

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

chri5tia
Copy link
Contributor

Description

Relates to #15222

Releases the lock down of the Benefit Name and ID fields for during the staging process of that content.

Note: Non-admins do not right now have access to this form but I structured the code so that it will be easier to lock down in the future as well as ensure that those fields aren't exposed to non-admins should access be granted to them.

Testing done

Functional.

Screenshots

Screenshot 2023-09-15 at 7 05 13 AM

QA steps

  1. Log in as a testcontentadmin and got to admin/structure/taxonomy/manage/va_benefits_taxonomy/add
    • Make sure the Name field is editable
    • Make sure the ID field is editable

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 15, 2023 14:10 Destroyed
@chri5tia chri5tia requested a review from dsasser September 15, 2023 14:10
config/sync/core.extension.yml Outdated Show resolved Hide resolved
@chri5tia chri5tia force-pushed the VACMS-15222-Unlock-Benefit-Taxonomy-Fields branch from de3304e to 2019567 Compare September 15, 2023 18:07
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 15, 2023 18:07 Destroyed
@chri5tia chri5tia requested a review from dsasser September 15, 2023 18:09
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 15, 2023 19:27 Destroyed
@chri5tia chri5tia merged commit 788f54f into main Sep 15, 2023
@chri5tia chri5tia deleted the VACMS-15222-Unlock-Benefit-Taxonomy-Fields branch September 15, 2023 20:06
@dsasser dsasser mentioned this pull request Nov 13, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants