Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Centralized Content for VBA #14699

Closed
4 tasks done
xiongjaneg opened this issue Aug 8, 2023 · 14 comments
Closed
4 tasks done

Implement Centralized Content for VBA #14699

xiongjaneg opened this issue Aug 8, 2023 · 14 comments
Assignees
Labels
Centralized Content A content type used across Facilties content Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Regional office CMS managed VBA product owned by the Facilities team sitewide

Comments

@xiongjaneg
Copy link
Contributor

xiongjaneg commented Aug 8, 2023

Description

Drupal implementation for VBA Centralized Content is built based on spec #13799. See comments in that ticket for screenshots. There is no spreadsheet version of this spec, because it uses existing fields & screenshots suffice.

Acceptance Criteria

  • Fields, machine names, help text, required, cardinality, character limits and any other Drupal implementation specifics are implemented as specified in the spec
  • Fields appear within fieldsets and in order as shown in the spec
  • Follow up tickets are created to track any remaining work that arises during implementation
  • After deploy to production, centralized content fields (of type Entity Field Fetch) are populated on VBA Facility pages through Bulk Edit (Modify field values).
@davidmpickett
Copy link
Contributor

Question for @swirtSJW and @omahane:

@davidmpickett
Copy link
Contributor

One other thing I want to call out that might be a stretch is that the requested model for spotlights is slightly more complex than Vet Center (I think). Rather than 1 national + up to 2 local for a total of 1-3, they want to ensure all three slots are always use, by having 2 national backfills for when no local content is there. This might be worth breaking off as a bonus enhancement for fast-follow, since it would only directly affect National Editors.

265146980-b3263a43-127e-4608-8632-d7818d33d431

@xiongjaneg xiongjaneg changed the title Implement Centralized Content content type for VBA Implement Centralized Content for VBA Sep 20, 2023
@xiongjaneg
Copy link
Contributor Author

xiongjaneg commented Sep 20, 2023

Needs the text for the documenter paragraph and the field. Sync with Dave P. on this. When CC is created, the paragraph type is needed and a field documenter above it that tells the national editor more info about where it's going to appear and what should be in it.

@davidmpickett
Copy link
Contributor

davidmpickett commented Sep 28, 2023

Christian's work is blocked by my review of

  • Titles of descriptors (because these will be used as basis for machine names of entity field fetch fields on VBA facility content type)
  • Field Paragraph types of all content input fields - make sure they are correct

@davidmpickett
Copy link
Contributor

Once the VBA Centralized Content type exists, there would likely then be additional work to update the #14701 to show gray boxes of Centralized Content. Would you consider that a separate ticket, or part and parcel of this ticket?

Per my chat with @omahane - the answer to this question is yes. Adding entity field fetch fields to the VBA Facility content type is the bulk of the work from an engineering perspective

@davidmpickett
Copy link
Contributor

davidmpickett commented Sep 29, 2023

Copy and pasting the current content of the node here so I can recommend changes

  • Title: National VBA facilities content
  • Product: VBA facilities
  • Applied to: [ null ]
  • Purpose: This is used on all VBA facility pages
  • Centralized content 1
    • Content descriptor title: VBA Facility overview
    • content_block aka Paragraph type: Rich text
  • Centralized content 2
    • Content descriptor title: Benefits hotline
    • content_block aka Paragraph type: Phone number
  • Centralized content 3
    • Content descriptor title: Hours advisory
    • content_block aka Paragraph type: Rich text
  • Centralized content 4
    • Content descriptor title: The featured "spotlight" content on all Vet Center pages
    • content_block aka Paragraph type: Featured content
  • Centralized content 5
    • Content descriptor title: Other services advisory
    • content_block aka Paragraph type: Featured content
  • Centralized content 6
    • Content descriptor title: Updates links
    • content_block aka Paragraph type: List of links

@davidmpickett
Copy link
Contributor

davidmpickett commented Sep 29, 2023

Names are hard note:
The field with machine name content_block does not map directly to either of the Drupal entities that start with the word content or block (content type / block layout). In fact it is a field that references Paragraph types.

@davidmpickett
Copy link
Contributor

Screenshot of current state

screencapture-staging-cms-va-gov-centralized-content-national-vba-facilities-content-2023-09-29-14_45_45

@davidmpickett
Copy link
Contributor

Side question for @omahane @swirtSJW about Centralized Content that could spin off into it's own ticket:

Do the Product and Applied to fields actually do anything? They seem like vestigial fields that were intended to help with documentation, and information that previously would have been populated there could now live in Content Model Documentation instead?

Screenshot 2023-09-29 145140

@omahane
Copy link
Contributor

omahane commented Sep 29, 2023

@davidmpickett I'm not sure if they have any effect. I think they're just self-documenting.

@davidmpickett
Copy link
Contributor

davidmpickett commented Oct 2, 2023

@omahane - proposed changes in bold. Notes in italics

  • Title: National VA benefit office content
    • Rationale: We do not know if this content will also be used on the VBA facility types that are outside of MVP scope. This content only applies to VA Regional Benefit Offices and VA Regional Benefit Satellite Offices. VBA facility may be too broad of a name in this instance. "Benefit Office" encompasses the two types we are designing for and excludes the others.
  • Product: VBA facilities
  • Applied to: [ null ]
  • Purpose: This content displays on all regional & satellite benefit office pages.
  • Centralized content 1
    • Content descriptor title: Benefit office overview
    • content_block: rich_text_char_limit_1000
  • Centralized content 2
    • Content descriptor title: VA benefits hotline
    • content_block: Phone number
  • Centralized content 3
    • Content descriptor title: Benefit office hours may vary
    • content_block: rich_text_char_limit_1000
  • Centralized content 4
    • Content descriptor title: The featured "spotlight" content on all VA benefit office pages
    • content_block: Featured content
      • Question: Are you thinking that this will be a paragraph with cardinality 3 to account for the national backfill? Or do we need three separate fields here?
  • Centralized content 5
    • Content descriptor title: Can't find the benefit service you're looking for?
    • content_block: Featured content
  • Centralized content 6
    • Content descriptor title: Get updates from VBA
    • content_block: List of links

@omahane
Copy link
Contributor

omahane commented Oct 2, 2023

Question: Are you thinking that this will be a paragraph with cardinality 3 to account for the national backfill? Or do we need three separate fields here?

I don't see any way to set the cardinality of a paragraph distinct from the cardinality of the field that references it. I think it makes sense to have three of these and they get filled in by national editors and are used as 1, 2 or all 3, depending on the number of facility-specific spotlight items.

@xiongjaneg Spotlight is not something that's been captured as a field in the Facility (if that is indeed where it should go) (CC: @davidmpickett )

@swirtSJW
Copy link
Contributor

swirtSJW commented Oct 6, 2023

Side question for @omahane @swirtSJW about Centralized Content that could spin off into it's own ticket:

Do the Product and Applied to fields actually do anything? They seem like vestigial fields that were intended to help with documentation, and information that previously would have been populated there could now live in Content Model Documentation instead?

@davidmpickett and @omahane

They do not currently apply to anything in a systemic/automated way. They are locked down fields for editors and were intended to give as much context as possible to the what and where.
image
Notice on the left, an assigned editor does not see them as fields. Only admins see the field. They are meant to be set up at the beginning by the admin who instantiates the Centralized content node so that we do not have all these Centralized content nodes created that nobody understands the context for.

It is similar but different than a Content Model Document.

The product field does not change the behavior of the node itself but it does tie it to the product taxononmy and at some point can help surface these at a product level.

It is easy now while we only have 8 Centralized content nodes to recognise what goes where, but this was built with there potentially being hundreds.

@jilladams
Copy link
Contributor

@omahane Closing based on demo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Centralized Content A content type used across Facilties content Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Regional office CMS managed VBA product owned by the Facilities team sitewide
Projects
None yet
Development

No branches or pull requests

5 participants