-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-14699: Adding a Entity Field Fetch fields for VBA Centralized content #15528
Conversation
1abae32
to
cff29a2
Compare
config/sync/field.field.node.vba_facility.field_cc_vba_facility_overview.yml
Outdated
Show resolved
Hide resolved
config/sync/field.field.node.vba_facility.field_can_t_find_benefits.yml
Outdated
Show resolved
Hide resolved
config/sync/field.field.node.vba_facility.field_benefit_office_hours_may_v.yml
Outdated
Show resolved
Hide resolved
303b921
to
a13705b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One set of suggested changes to make the machine name more friendly and meaningful for front end.
config/sync/core.entity_form_display.node.vba_facility.default.yml
Outdated
Show resolved
Hide resolved
config/sync/core.entity_form_display.node.vba_facility.default.yml
Outdated
Show resolved
Hide resolved
config/sync/core.entity_view_display.node.vba_facility.default.yml
Outdated
Show resolved
Hide resolved
config/sync/core.entity_view_display.node.vba_facility.default.yml
Outdated
Show resolved
Hide resolved
I was trying to follow the layout from the FE, which sandwiches this number right after the main number and before the hours for editor clarity, but if this is confusing, I could put it elsewhere. After? |
This was unintentional. @davidmpickett I think I should include the updated date. What do you think? |
I agree so heartily that I fleshed out a whole ticket about how I think this should be the default pattern: #4055 |
|
e53d709
to
4cdde28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome. Nice work and thanks for sticking it out through all the changes.
4cdde28
to
60692d4
Compare
Description
Relates to #14699
Testing done
Manually
Screenshots
node:view
node:edit
QA steps
Reviewing node:view of a VBA facility
Reviewing node:edit of a VBA facility
Editing VBA Centralized Content
Select Team for PR review
CMS Team
Public websites
Facilities
User support
Accelerated Publishing