Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-14699: Adding a Entity Field Fetch fields for VBA Centralized content #15528

Merged
merged 7 commits into from
Oct 6, 2023

Conversation

omahane
Copy link
Contributor

@omahane omahane commented Oct 3, 2023

Description

Relates to #14699

Testing done

Manually

Screenshots

node:view

Screenshot 2023-10-04 at 2 13 27 PM

node:edit

Screenshot 2023-10-04 at 2 15 26 PM

QA steps

Reviewing node:view of a VBA facility

  • As an admin, visit to a VBA facility in node:view
  • Confirm that the following fields are being fetched:
    • Benefit office overview
    • Benefits hotline
    • Benefit office hours may vary
    • National spotlight 1
    • National spotlight 2
    • National spotlight 3
    • Can't find benefits
    • Get updates from VBA
  • Confirm that each fetched field is in a grey box
  • Confirm that each fetched field has a tooltip that pops up when hovering over the question mark

Reviewing node:edit of a VBA facility

  • As an admin, edit [a VBA facility]https://pr15528-0squmrsgqim6fn8sjpgkwzrlslxcq25u.ci.cms.va.gov/node/61682/edit)
  • Confirm that the following fields are being fetched:
    • Benefit office overview
    • Benefits hotline
    • Benefit office hours may vary
    • National spotlight 1
    • National spotlight 2
    • National spotlight 3
    • Can't find benefits
    • Get updates from VBA
  • Confirm that each fetched field is in a grey box
  • Confirm that each fetched field has a tooltip that pops up when hovering over the question mark
  • Make a change to the facility
  • Save
  • Confirm that the fetched fields and change you made are showing on node:view

Editing VBA Centralized Content

  • As an editor, edit the National VA benefit office content
  • Make a change to the content in the "Rich text - char limit 1000" paragraph under the "Benefit office overview" Centralized content descriptor
  • Save
  • Visit to a VBA facility in node:view
  • Confirm that your change is reflected in the "Benefit office overview" field

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 3, 2023 17:17 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 4, 2023 18:13 Destroyed
@omahane omahane changed the title VACMS-14699: Adding a couple fields. VACMS-14699: Adding a Entity Field Fetch fields for VBA Centralized content Oct 4, 2023
@omahane omahane force-pushed the VACMS-14699-implement-centralized-content-vba branch from 1abae32 to cff29a2 Compare October 4, 2023 18:20
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 4, 2023 18:20 Destroyed
@github-actions github-actions bot added the Facilities Facilities products (VAMC, Vet Center, etc) label Oct 4, 2023
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 5, 2023 13:59 Destroyed
@omahane omahane force-pushed the VACMS-14699-implement-centralized-content-vba branch from 303b921 to a13705b Compare October 5, 2023 14:07
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 5, 2023 14:08 Destroyed
@omahane omahane requested a review from davidmpickett October 5, 2023 14:24
Copy link
Contributor

@swirtSJW swirtSJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One set of suggested changes to make the machine name more friendly and meaningful for front end.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 5, 2023 15:28 Destroyed
@omahane omahane requested a review from swirtSJW October 5, 2023 15:36
@swirtSJW
Copy link
Contributor

swirtSJW commented Oct 5, 2023

This placement seems odd putting the centralized content inside the facility data section
image

Because it is not facility data and makes it look like it is coming from elsewhere.

@swirtSJW
Copy link
Contributor

swirtSJW commented Oct 5, 2023

Is it intentional that we are only showing the last updated date on once of the CC fields but not the other?
image
image

The date it going to be the same for all of them.. but it shows the source of each segment of the data.

@swirtSJW
Copy link
Contributor

swirtSJW commented Oct 5, 2023

Strikes me odd that these are rendering as separate link title and urls. It is going to be based on the default view mode for that paragraph.... which might not have had any attention when it was built.
image

I think it is unrelated to this ticket. Just noting it is odd.

@omahane
Copy link
Contributor Author

omahane commented Oct 5, 2023

This placement seems odd putting the centralized content inside the facility data section image

Because it is not facility data and makes it look like it is coming from elsewhere.

I was trying to follow the layout from the FE, which sandwiches this number right after the main number and before the hours for editor clarity, but if this is confusing, I could put it elsewhere. After?

Screenshot 2023-10-05 at 2 43 41 PM

@omahane
Copy link
Contributor Author

omahane commented Oct 5, 2023

Is it intentional that we are only showing the last updated date on once of the CC fields but not the other?
The date it going to be the same for all of them.. but it shows the source of each segment of the data.

This was unintentional. @davidmpickett I think I should include the updated date. What do you think?

@davidmpickett
Copy link
Contributor

Is it intentional that we are only showing the last updated date on once of the CC fields but not the other?
The date it going to be the same for all of them.. but it shows the source of each segment of the data.

This was unintentional. @davidmpickett I think I should include the updated date. What do you think?

I agree so heartily that I fleshed out a whole ticket about how I think this should be the default pattern: #4055

@swirtSJW
Copy link
Contributor

swirtSJW commented Oct 5, 2023

I agree so heartily that I fleshed out a whole ticket about how I think this should be the default pattern: #4055

It is all about ticking all the boxes 😀
image

@omahane omahane force-pushed the VACMS-14699-implement-centralized-content-vba branch from e53d709 to 4cdde28 Compare October 5, 2023 22:14
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 5, 2023 22:14 Destroyed
Copy link
Contributor

@swirtSJW swirtSJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome. Nice work and thanks for sticking it out through all the changes.

@swirtSJW
Copy link
Contributor

swirtSJW commented Oct 6, 2023

image

@swirtSJW swirtSJW force-pushed the VACMS-14699-implement-centralized-content-vba branch from 4cdde28 to 60692d4 Compare October 6, 2023 17:23
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 6, 2023 17:23 Destroyed
@swirtSJW swirtSJW merged commit 70a3951 into main Oct 6, 2023
13 checks passed
@swirtSJW swirtSJW deleted the VACMS-14699-implement-centralized-content-vba branch October 6, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants