Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Trigger component conditions validation #819

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

nicoecheza
Copy link
Contributor

@nicoecheza nicoecheza commented Nov 1, 2023

closes decentraland/sdk#982

🤖 Generated by Copilot at 1cbe795

Improved the validation and filtering of trigger actions in the TriggerInspector component

Copy link

cloudflare-workers-and-pages bot commented Nov 1, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 939b45a
Status: ✅  Deploy successful!
Preview URL: https://63b495af.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-trigger-conditions.js-sdk-toolchain.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Nov 1, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/trigger-conditions/dcl-sdk-7.3.27-6785856247.commit-2b649b0.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/trigger-conditions/dcl-sdk-commands-7.3.27-6785856247.commit-2b649b0.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/trigger-conditions/@dcl/inspector/dcl-inspector-7.3.27-6785856247.commit-2b649b0.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/trigger-conditions-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/trigger-conditions

@nicoecheza nicoecheza force-pushed the fix/trigger-conditions branch 2 times, most recently from fc88ae9 to c32ec60 Compare November 1, 2023 13:19
@nicoecheza nicoecheza marked this pull request as ready for review November 1, 2023 13:20
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6b8ca94) 70.52% compared to head (feb4fe6) 70.55%.
Report is 2 commits behind head on main.

❗ Current head feb4fe6 differs from pull request most recent head 939b45a. Consider uploading reports for the commit 939b45a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #819      +/-   ##
==========================================
+ Coverage   70.52%   70.55%   +0.03%     
==========================================
  Files         399      399              
  Lines       13114    13128      +14     
  Branches     1715     1723       +8     
==========================================
+ Hits         9248     9262      +14     
  Misses       3652     3652              
  Partials      214      214              
Files Coverage Δ
...ages/@dcl/react-ecs/src/components/Input/index.tsx 100.00% <ø> (ø)
packages/@dcl/react-ecs/src/reconciler/index.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicoecheza nicoecheza force-pushed the fix/trigger-conditions branch 4 times, most recently from 5913ff3 to 6fdd99a Compare November 2, 2023 13:54
@nicoecheza nicoecheza enabled auto-merge (squash) November 2, 2023 14:32
@nicoecheza nicoecheza force-pushed the fix/trigger-conditions branch from 6fdd99a to feb4fe6 Compare November 7, 2023 14:13
@nicoecheza nicoecheza force-pushed the fix/trigger-conditions branch from feb4fe6 to 939b45a Compare November 7, 2023 14:23
@nicoecheza nicoecheza merged commit db59bf1 into main Nov 7, 2023
8 checks passed
@nicoecheza nicoecheza deleted the fix/trigger-conditions branch November 7, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trigger doesn't accept values if do one event
2 participants