fix: Trigger component conditions validation

decentraland · Nov 1, 2023 · fc88ae9 · fc88ae9
1 parent d90c0f5
commit fc88ae9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/packages/@dcl/inspector/src/components/EntityInspector/TriggerInspector/TriggerInspector.tsx b/packages/@dcl/inspector/src/components/EntityInspector/TriggerInspector/TriggerInspector.tsx
@@ -71,17 +71,14 @@ export default withSdk<Props>(
     const hasCounter = useHasComponent(entityId, Counter)
 
     const areValidActions = useCallback(
-      (updatedActions: TriggerAction[]) =>
-        updatedActions.length > 0 && updatedActions.every((action) => action.id && action.name),
-      []
+      (updatedActions: TriggerAction[]) => updatedActions.every((action) => action.id && action.name),
+      [triggers]
     )
 
     const areValidConditions = useCallback(
-      (updatedConditions: TriggerCondition[] | undefined) =>
-        updatedConditions && updatedConditions.length > 0
-          ? updatedConditions.every((condition) => condition.id && condition.value)
-          : true,
-      []
+      (updatedConditions: TriggerCondition[] = []) =>
+        updatedConditions.every((condition) => condition.id && condition.value),
+      [triggers]
     )
 
     const areValidTriggers = useCallback(
@@ -97,6 +94,7 @@ export default withSdk<Props>(
     )
 
     useEffect(() => {
+      console.log('trigggers', triggers)
       if (areValidTriggers(triggers)) {
         if (isComponentEqual({ value: triggers })) {
           return

diff --git a/packages/@dcl/inspector/src/lib/sdk/operations/add-asset.ts b/packages/@dcl/inspector/src/lib/sdk/operations/add-asset.ts
@@ -108,10 +108,12 @@ export function addAsset(engine: IEngine) {
                 ...condition,
                 id: mapId(condition.id)
               })),
-              actions: trigger.actions.map((action) => ({
-                ...action,
-                id: mapId(action.id)
-              }))
+              actions: trigger.actions
+                .filter((action) => action.id)
+                .map((action) => ({
+                  ...action,
+                  id: mapId(action.id)
+                }))
             }))
             values.set(componentName, { ...triggers, value: newValue })
             break