fix: Trigger component conditions validation (#819)

decentraland · Nov 7, 2023 · db59bf1 · db59bf1
1 parent 4458751
commit db59bf1
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 20 deletions.
diff --git a/packages/@dcl/inspector/package-lock.json b/packages/@dcl/inspector/package-lock.json
diff --git a/packages/@dcl/inspector/package.json b/packages/@dcl/inspector/package.json
@@ -2,7 +2,7 @@
   "name": "@dcl/inspector",
   "version": "0.1.0",
   "dependencies": {
-    "@dcl/asset-packs": "^1.2.5"
+    "@dcl/asset-packs": "^1.2.8"
   },
   "devDependencies": {
     "@babylonjs/core": "^6.18.0",

diff --git a/packages/@dcl/inspector/src/components/EntityInspector/TriggerInspector/TriggerInspector.tsx b/packages/@dcl/inspector/src/components/EntityInspector/TriggerInspector/TriggerInspector.tsx
@@ -71,16 +71,13 @@ export default withSdk<Props>(
     const hasCounter = useHasComponent(entityId, Counter)
 
     const areValidActions = useCallback(
-      (updatedActions: TriggerAction[]) =>
-        updatedActions.length > 0 && updatedActions.every((action) => action.id && action.name),
+      (updatedActions: TriggerAction[]) => updatedActions.every((action) => action.id && action.name),
       []
     )
 
     const areValidConditions = useCallback(
-      (updatedConditions: TriggerCondition[] | undefined) =>
-        updatedConditions && updatedConditions.length > 0
-          ? updatedConditions.every((condition) => condition.id && condition.value)
-          : true,
+      (updatedConditions: TriggerCondition[] = []) =>
+        updatedConditions.every((condition) => condition.id && condition.value),
       []
     )
 

diff --git a/packages/@dcl/inspector/test/e2e/Assets.spec.ts b/packages/@dcl/inspector/test/e2e/Assets.spec.ts
@@ -13,17 +13,17 @@ describe('Assets', () => {
   }, 100_000)
 
   test('Drag asset from file system into renderer', async () => {
-    // There should not be an entity in the Hierarchy tree with the name casla.glb at the start
-    await expect(Hierarchy.getId('casla-glb.glb')).rejects.toThrow()
+    // There should not be an entity in the Hierarchy tree with the name example.glb at the start
+    await expect(Hierarchy.getId('example.glb')).rejects.toThrow()
 
     await Assets.selectTab(AssetsTab.FileSystem)
     await Assets.openFolder('scene')
-    await Assets.openFolder('scene/models2')
+    await Assets.openFolder('scene/models')
 
-    await Assets.addFileSystemAsset('scene/models2/casla-glb.glb')
+    await Assets.addFileSystemAsset('scene/models/example.glb')
 
-    // There should be an entity in the Hierarchy tree with the name Pebbles
-    await expect(Hierarchy.getId('casla-glb.glb')).resolves.toBeGreaterThanOrEqual(152)
+    // There should be an entity in the Hierarchy tree with the name example.glb
+    await expect(Hierarchy.getId('example.glb')).resolves.toBeGreaterThanOrEqual(152)
   }, 100_000)
 
   test('Drag asset from Builder into renderer', async () => {