add cumulative metrics granularity info #5688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
mirnawong1
commented
Jun 24, 2024
| | `grain_to_date` | Sets the accumulation grain, such as month will accumulate data for one month. Then restart at the beginning of the next. This can't be used with `window`. | Optional | | ||
| | `type_param:window` | The accumulation window, such as 1 month, 7 days, 1 year. This can't be used with `grain_to_date`. | Optional | | ||
| | `type_param:grain_to_date` | Sets the accumulation grain, such as `month`, which will accumulate data for one month. Then restart at the beginning of the next. This can't be used with `window`. | Optional | | ||
| | `type_param:period_agg` | Specifies how to roll up the cumulative metric to another granularity. Options are `start`, `end`, `average`. Defaults to `start` if no `window` is specified. | Optional | |
There was a problem hiding this comment.
@Jstein77 I'm not sure I udnerstand the definition? And what does teh start/end/avg mean?
mirnawong1
commented
Jun 24, 2024
| | `type_param:window` | The accumulation window, such as 1 month, 7 days, 1 year. This can't be used with `grain_to_date`. | Optional | | ||
| | `type_param:grain_to_date` | Sets the accumulation grain, such as `month`, which will accumulate data for one month. Then restart at the beginning of the next. This can't be used with `window`. | Optional | | ||
| | `type_param:period_agg` | Specifies how to roll up the cumulative metric to another granularity. Options are `start`, `end`, `average`. Defaults to `start` if no `window` is specified. | Optional | | ||
| | `type_param:window_choice` | Specifies whether to take the cumulative metric value from the beginning (min) or end (max) of the window. Defaults to `min`. | Optional | |
There was a problem hiding this comment.
@Jstein77 is this right? and can window_choice and period_agg be used with window and grain_to_date?
mirnawong1
commented
Jun 24, 2024
mirnawong1
commented
Jun 24, 2024
mirnawong1
commented
Jun 24, 2024
mirnawong1
commented
Jun 24, 2024
mirnawong1
commented
Jun 24, 2024
mirnawong1
commented
Jun 24, 2024
mirnawong1
commented
Jun 26, 2024
mirnawong1
commented
Jun 27, 2024
| `period_agg` is set to first so we will choose the first value for the select granularity window. Let's say we cumulative_revenue by week using the following query: `dbt sl query --metrics cumulative_revenue --group-by metric_time__week`. | ||
|
|
||
| This compiles the following SQl, Note the use of the window function to select the first value: | ||
|
|
There was a problem hiding this comment.
@Jstein77 i'm not sure i understand the diff btw first_value(), etc. here compared to first. but is this placed correctly
There was a problem hiding this comment.
It's because we use the first_value() function in the generated SQL. We can remove this if it's confusing.
nataliefiann
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Hiya @mirnawong1
Thanks for flagging this. This is amazing! No suggestions or changes from me. Let me know if there's anything else I can do to help on this.
Kind Regards
Natalie
mirnawong1
commented
Jun 28, 2024
mirnawong1
commented
Jun 28, 2024
mirnawong1
commented
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds suuport for cumulative metrics granularity options info per notion spec
[x ] Outstanding questions need resolving
[ x] Needs review by PM @Jstein77
[ x] Needs docs review (optional)
[ x] Do not merge yet until dbt core pr is merged
docs project