fix(cumulative metrics): fix some typos #5722
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
|
hey @gwenwindflower ! thanks for flagging this and opening this pr! I've actually captured the typo in this pr here: https://github.com/dbt-labs/docs.getdbt.com/pull/5688/files#diff-d5effaa3526d0e8fd91e0abfacddbd23acf282f7630b5f0fad324cd2f0ecab9fR19-R36 but am just waiting to confirm when to merge. I've folded in your I'll close this pr up if that's ok with you since it's captured in pr #5688 and it'll help me avoid any merge conflicts 🙏 please let me know if you think otherwise though! |
|
@mirnawong1 oh nice! yep all good by me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple quick things I noticed while exploring stuff.