-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cumulative metrics granularity info #5688
Merged
Merged
Changes from 9 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
acead33
add cumulative metrics info
mirnawong1 f0ec4cc
dbt sql
mirnawong1 7e76ad3
Merge branch 'current' into mwong-add-granularity-cumulative-metrics
mirnawong1 4ba8dfd
Merge branch 'current' into mwong-add-granularity-cumulative-metrics
mirnawong1 ee34960
Update website/docs/docs/build/cumulative-metrics.md
mirnawong1 f2d5ced
Update cumulative-metrics.md
mirnawong1 a34778e
updated to cumulative metrics docs
Jstein77 cb2986e
updated to cumulative metrics docs
Jstein77 5dc290d
Merge branch 'current' into mwong-add-granularity-cumulative-metrics
mirnawong1 f6a6b83
add updates
mirnawong1 befd1ae
Merge branch 'current' into mwong-add-granularity-cumulative-metrics
mirnawong1 9eec57b
add expandable and more context to example
mirnawong1 c0272c6
add context to window exmaples
mirnawong1 4313c7e
typos
mirnawong1 573403f
Merge branch 'current' into mwong-add-granularity-cumulative-metrics
mirnawong1 f04d77b
Update website/docs/docs/build/cumulative-metrics.md
mirnawong1 72aac6b
Update cumulative-metrics.md
mirnawong1 9b922f2
update table
mirnawong1 68be176
Update release-notes.md
mirnawong1 4ccf1f4
Update cumulative-metrics.md
mirnawong1 4227693
Update release-notes.md
mirnawong1 4aee683
Update cumulative-metrics.md
mirnawong1 37723c3
Merge branch 'current' into mwong-add-granularity-cumulative-metrics
mirnawong1 674e412
Merge branch 'current' into mwong-add-granularity-cumulative-metrics
mirnawong1 0ab1f22
Update website/docs/docs/build/cumulative-metrics.md
mirnawong1 cf6b231
Merge branch 'current' into mwong-add-granularity-cumulative-metrics
mirnawong1 fac61b0
Merge branch 'current' into mwong-add-granularity-cumulative-metrics
mirnawong1 89526aa
Merge branch 'current' into mwong-add-granularity-cumulative-metrics
mirnawong1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jstein77 i'm not sure i understand the diff btw
first_value()
, etc. here compared tofirst
. but is this placed correctlyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because we use the
first_value()
function in the generated SQL. We can remove this if it's confusing.