-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conflict with newer versions of Snowplow tracker #9528
Fix conflict with newer versions of Snowplow tracker #9528
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Thanks for moving this over from #8680 @edgarrmondragon ! Could you use That will satisfy one of the CI checks and allow us to kick off the rest of the CI checks. |
Using a kwarg should make this compatible: snowplow/snowplow-python-tracker@f2c6b36
@dbeatty10 this is ready for review! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9528 +/- ##
==========================================
- Coverage 87.94% 85.53% -2.42%
==========================================
Files 168 168
Lines 22208 22212 +4
==========================================
- Hits 19531 18998 -533
- Misses 2677 3214 +537
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@dbeatty10 is there anything left to do here from my side? I noticed that coverage dropped but some workflows did not run I think, so I wonder if that's the cause. |
Nothing on your side right now, when we have capacity, a member of our engineering team will give it a review. In the meantime, I kicked off those workflows. |
|
Oh no! What happens if you update your branch name to remove the |
I don't think I can do that without closing the PR 😭. Should I go ahead and open a fresh PR with an acceptable branch name? |
Yes, let's do that. Sorry about the hassle on this @edgarrmondragon |
No worries @dbeatty10! Superseded by #9680 |
resolves #8719
Problem
Instaling
dbt-core
withmeltano
in the same virtualenv breaks dbt because contract conflict betweenminimal-snowplow-tracker
(dependency of dbt) andsnowplow-python-tracker
.Solution
Adds explicit version check and use
minimal
orfull
contract call.Checklist
Based on #8680, by @akurdyukov.