Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflict with newer versions of Snowplow tracker #9528

Closed
wants to merge 8 commits into from
Closed

Fix conflict with newer versions of Snowplow tracker #9528

wants to merge 8 commits into from

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Feb 6, 2024

resolves #8719

Problem

Instaling dbt-core with meltano in the same virtualenv breaks dbt because contract conflict between minimal-snowplow-tracker (dependency of dbt) and snowplow-python-tracker.

Solution

Adds explicit version check and use minimal or full contract call.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

Based on #8680, by @akurdyukov.

@cla-bot cla-bot bot added the cla:yes label Feb 6, 2024
Copy link
Contributor

github-actions bot commented Feb 6, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@dbeatty10
Copy link
Contributor

Thanks for moving this over from #8680 @edgarrmondragon !

Could you use changie new as described here to add a changelog entry?

That will satisfy one of the CI checks and allow us to kick off the rest of the CI checks.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review February 6, 2024 22:04
@edgarrmondragon edgarrmondragon requested a review from a team as a code owner February 6, 2024 22:04
@edgarrmondragon edgarrmondragon marked this pull request as draft February 6, 2024 22:42
@edgarrmondragon edgarrmondragon marked this pull request as ready for review February 6, 2024 22:42
@edgarrmondragon
Copy link
Contributor Author

@dbeatty10 this is ready for review!

@dbeatty10 dbeatty10 added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8a1b927) 87.94% compared to head (cc1a9e2) 85.53%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9528      +/-   ##
==========================================
- Coverage   87.94%   85.53%   -2.42%     
==========================================
  Files         168      168              
  Lines       22208    22212       +4     
==========================================
- Hits        19531    18998     -533     
- Misses       2677     3214     +537     
Flag Coverage Δ
integration 85.53% <100.00%> (+<0.01%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon
Copy link
Contributor Author

@dbeatty10 is there anything left to do here from my side? I noticed that coverage dropped but some workflows did not run I think, so I wonder if that's the cause.

@dbeatty10
Copy link
Contributor

@dbeatty10 is there anything left to do here from my side? I noticed that coverage dropped but some workflows did not run I think, so I wonder if that's the cause.

Nothing on your side right now, when we have capacity, a member of our engineering team will give it a review.

In the meantime, I kicked off those workflows.

@edgarrmondragon
Copy link
Contributor Author

check-artifact-changes doesn't like my branch name 😶

@dbeatty10
Copy link
Contributor

check-artifact-changes doesn't like my branch name 😶

Oh no! What happens if you update your branch name to remove the fix/ portion?

@edgarrmondragon
Copy link
Contributor Author

check-artifact-changes doesn't like my branch name 😶

Oh no! What happens if you update your branch name to remove the fix/ portion?

From https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-branches-in-your-repository/renaming-a-branch

If the renamed branch is the head branch of an open pull request, this pull request is closed.

I don't think I can do that without closing the PR 😭. Should I go ahead and open a fresh PR with an acceptable branch name?

@dbeatty10
Copy link
Contributor

I don't think I can do that without closing the PR 😭. Should I go ahead and open a fresh PR with an acceptable branch name?

Yes, let's do that.

Sorry about the hassle on this @edgarrmondragon

@edgarrmondragon
Copy link
Contributor Author

No worries @dbeatty10!

Superseded by #9680

@edgarrmondragon edgarrmondragon deleted the fix/snowplow-tracker-conflict branch February 27, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
3 participants