-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix conflict for real not minimal snowplow tracker #8680
fix conflict for real not minimal snowplow tracker #8680
Conversation
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @akurdyukov |
Hey - thanks so much for opening this up! Is there is a reason you targeted the |
Temporarily added This label should be removed prior to final review + merge. |
Yes, I needed get it working with dbt-clickhouse which is compatible with 1.4 only. I can open new PR to |
…snowplow-tracker-conflict
I'm not sure if it's correct but I fixed mypy error by ignoring. |
Hey @akurdyukov - I tried to re-point this PR to the main branch, but got a handful of merge conflicts. Would you be able to take a look? Thanks! |
Closes issue meltano#8256 It may be a temporary woraround - it may be removed once dbt-labs/dbt-core#8680 is merged.
Closes issue meltano#8256 It may be a temporary workaround - it may be removed once dbt-labs/dbt-core#8680 is merged.
This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days. |
@graciegoheen do you think this PR can be salvaged or is it better to start a fresh one targeting |
@edgarrmondragon A fresh one targeting the In the meantime, I switched this PR back to targeting the |
Closes issue meltano#8256 It may be a temporary workaround - it may be removed once dbt-labs/dbt-core#8680 is merged.
Closes issue meltano#8256 It may be a temporary workaround - it may be removed once dbt-labs/dbt-core#8680 is merged.
Closes issue meltano#8256 It may be a temporary workaround - it may be removed once dbt-labs/dbt-core#8680 is merged.
Closes issue meltano#8256 It may be a temporary workaround - it may be removed once dbt-labs/dbt-core#8680 is merged.
Closes issue meltano#8256 It may be a temporary workaround - it may be removed once dbt-labs/dbt-core#8680 is merged.
Is there any progress on this @edgarrmondragon? Running into the same issue working with Meltano + dbt |
|
Thanks for doing that @edgarrmondragon 🙏 Closing this one in favor of #9528 |
@edgarrmondragon Thank you for the update 🙏 Will track that issue! |
From #8719
Closes #8719
Problem
Instaling
dbt-core
withmeltano
in the same virtualenv breaks dbt because contract conflict betweenminimal-snowplow-tracker
(dependency of dbt) andsnowplow-python-tracker
.Solution
Adds explicit version check and use
minimal
orfull
contract call.Checklist