Restore msg_to_dict functionality #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenyuLInx
approved these changes
Jan 29, 2024
| @@ -94,7 +94,7 @@ def msg_to_dict(msg: EventMsg) -> dict: | |||
| msg_dict = dict() | |||
| try: | |||
| msg_dict = MessageToDict( | |||
| msg.data, | |||
There was a problem hiding this comment.
Why this was not caught by CI in this repo? Can we make sure there are some issue tracking adding tests?
There was a problem hiding this comment.
I opened #50 to track the testing work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Accidentally updated in hatch / formatting work: https://github.com/dbt-labs/dbt-common/pull/21/files#diff-2b8708e3235a909b0f4cd6963af306d4c625d27b723d2fbf1878b0f4f6dce541R97
Checklist
changie newto create a changelog entry