Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore msg_to_dict functionality #49

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Restore msg_to_dict functionality #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dbt_common/events/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def msg_to_dict(msg: EventMsg) -> dict:
msg_dict = dict()
try:
msg_dict = MessageToDict(
msg.data,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this was not caught by CI in this repo? Can we make sure there are some issue tracking adding tests?

Copy link
Member

@emmyoop emmyoop Jan 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #50 to track the testing work

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests added in #51

msg,
preserving_proto_field_name=True,
including_default_value_fields=True, # type: ignore
)
Expand Down
Loading