Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event testing #51

Merged
merged 12 commits into from
Feb 6, 2024
Merged

Add event testing #51

merged 12 commits into from
Feb 6, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Jan 30, 2024

resolves #50

Description

  • Adds testing for event system

Additional fixes found while adding tests

  • Fixes missing coverage setup
  • Fixes CI to actually fail when tests fail

Checklist

@emmyoop emmyoop requested a review from a team as a code owner January 30, 2024 15:35
@emmyoop emmyoop changed the title Er/event testing Add event testing Jan 30, 2024
@emmyoop emmyoop mentioned this pull request Jan 30, 2024
6 tasks
@emmyoop
Copy link
Member Author

emmyoop commented Jan 30, 2024

Tests are expected to fail until #49 is merged

pyproject.toml Outdated Show resolved Hide resolved
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7aa35e5) 51.47% compared to head (ec10b29) 52.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   51.47%   52.31%   +0.84%     
==========================================
  Files          49       49              
  Lines        2856     2856              
==========================================
+ Hits         1470     1494      +24     
+ Misses       1386     1362      -24     
Flag Coverage Δ
unit 52.31% <ø> (+0.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Jan 31, 2024
@emmyoop emmyoop requested a review from MichelleArk February 5, 2024 20:21
@emmyoop emmyoop mentioned this pull request Feb 6, 2024
5 tasks
Copy link
Collaborator

@MichelleArk MichelleArk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple small nits. otherwise looks good. thank you!

@emmyoop emmyoop added this pull request to the merge queue Feb 6, 2024
Merged via the queue into main with commit 3ab9179 Feb 6, 2024
12 checks passed
@emmyoop emmyoop deleted the er/event-testing branch February 6, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set Up event testing
3 participants