-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core-api][experimental] multi partition mappings #26686
Open
OwenKephart
wants to merge
1
commit into
12-23-_core-api_experimental_amp
Choose a base branch
from
12-23-_core-api_experimental_multi_partition_mappings
base: 12-23-_core-api_experimental_amp
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[core-api][experimental] multi partition mappings #26686
OwenKephart
wants to merge
1
commit into
12-23-_core-api_experimental_amp
from
12-23-_core-api_experimental_multi_partition_mappings
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
OwenKephart
force-pushed
the
12-23-_core-api_experimental_amp
branch
from
December 23, 2024 21:54
2e8e63b
to
ec805a4
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_multi_partition_mappings
branch
from
December 23, 2024 21:54
75e0102
to
54453df
Compare
i know this API itself is unlikely to change, but im wondering if we should mark it as "Beta" for the following reasons:
|
OwenKephart
force-pushed
the
12-23-_core-api_experimental_amp
branch
from
December 31, 2024 18:46
ec805a4
to
a553ee1
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_multi_partition_mappings
branch
from
December 31, 2024 18:46
54453df
to
bcdc49a
Compare
Draft
OwenKephart
force-pushed
the
12-23-_core-api_experimental_amp
branch
from
December 31, 2024 19:18
a553ee1
to
0e35f35
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_multi_partition_mappings
branch
from
December 31, 2024 19:18
bcdc49a
to
0a1a10b
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_amp
branch
from
December 31, 2024 19:30
0e35f35
to
3c155bd
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_multi_partition_mappings
branch
from
December 31, 2024 19:30
0a1a10b
to
7a9da34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
decision: experimental -> public
reason: these APIs have existed for many years without change, and are intertwined with serialized objects, making it extremely unlikely that we would change them
docs exist: yes (api only, which is ok)
How I Tested These Changes
Changelog