Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-api][experimental] multi partition mappings #26686

Open
wants to merge 1 commit into
base: 12-23-_core-api_experimental_amp
Choose a base branch
from

Conversation

OwenKephart
Copy link
Contributor

Summary & Motivation

decision: experimental -> public
reason: these APIs have existed for many years without change, and are intertwined with serialized objects, making it extremely unlikely that we would change them
docs exist: yes (api only, which is ok)

How I Tested These Changes

Changelog

Insert changelog entry or delete this section.

Copy link
Contributor Author

OwenKephart commented Dec 23, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

yuhan commented Dec 26, 2024

i know this API itself is unlikely to change, but im wondering if we should mark it as "Beta" for the following reasons:

  • its functionality is still limited given "Multipartitions definitions are currently limited to two dimensions" (docs)
  • i know jarred/sean are scoping some partition improvements, so maybe there's a chance for some holistic partition improvements including this API's functionality, so i kinda want to keep the possibility of making changes to it.

@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_amp branch from ec805a4 to a553ee1 Compare December 31, 2024 18:46
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_multi_partition_mappings branch from 54453df to bcdc49a Compare December 31, 2024 18:46
@OwenKephart OwenKephart mentioned this pull request Dec 31, 2024
@OwenKephart OwenKephart marked this pull request as ready for review December 31, 2024 18:51
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_amp branch from a553ee1 to 0e35f35 Compare December 31, 2024 19:18
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_multi_partition_mappings branch from bcdc49a to 0a1a10b Compare December 31, 2024 19:18
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_amp branch from 0e35f35 to 3c155bd Compare December 31, 2024 19:30
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_multi_partition_mappings branch from 0a1a10b to 7a9da34 Compare December 31, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants